Some changes to make tailcalls compile. #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… measuring. You should not see any compilations or invalidations in your code after that if -G:+TraceTruffleCompilation is enabled. If you do, you might have a problem in your interpreter.
…It might have been rewritting due to the first invocation. The method isTail can be asserted compilationConstant.
…ey may invalidate themselves through changes in the FrameDescriptor.
cesquivias
added a commit
that referenced
this pull request
Jan 15, 2015
Some changes to make tailcalls compile. I saw a change from 204ms to 2ms, but close enough :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before my changes:
('computation-time 204)
After my changes:
('computation-time 0)
Make sure you run it with -G:-TruffleBackgroundCompilation to ensure your countdown method is compiled.