New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The total number of reconnection attempts to be passed to reconnect option is wrong #5

Closed
flowersinthesand opened this Issue Jun 4, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@flowersinthesand
Member

flowersinthesand commented Jun 4, 2015

The reconnect option is a function to determine whether to schedule reconnection on this disconnection or not so that it should receive information which has been accumulated so far this disconnection. However in the current implementation the wrong total number of reconnection attempt is passed to the option. At first disconnection, 1 is passed but it should be 0 because there has never been an attempt to reconnect.

A fix to this issue won't affect to waiting event hander's arguments as it works correctly. In summary, at first disconnection, reconnect option should receive null and 0 as arguments and if it returns 500 waiting event handler should receive 500 and 1 as arguments, information about reconnection scheduled by reconnect option.

@flowersinthesand flowersinthesand added this to the 1.0.0-Alpha2 milestone Jun 4, 2015

@flowersinthesand flowersinthesand self-assigned this Feb 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment