Skip to content

The total number of reconnection attempts to be passed to reconnect option is wrong #5

Description

@flowersinthesand

The reconnect option is a function to determine whether to schedule reconnection on this disconnection or not so that it should receive information which has been accumulated so far this disconnection. However in the current implementation the wrong total number of reconnection attempt is passed to the option. At first disconnection, 1 is passed but it should be 0 because there has never been an attempt to reconnect.

A fix to this issue won't affect to waiting event hander's arguments as it works correctly. In summary, at first disconnection, reconnect option should receive null and 0 as arguments and if it returns 500 waiting event handler should receive 500 and 1 as arguments, information about reconnection scheduled by reconnect option.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions