Accept typed arrays in send method #10

flowersinthesand opened this Issue Mar 13, 2016 · 0 comments


None yet
1 participant

flowersinthesand commented Mar 13, 2016

As a result of cettia/cettia-javascript-client#9, it turns out that it is better to accept typed arrays as well as Buffer to handle binary data. That means, when determining if the given object is binary, ArrayBuffer.isView as well as Buffer.isBuffer should be used.

But, transport's binary event should accept Buffer only.

@flowersinthesand flowersinthesand added this to the 1.0.0-Beta1 milestone Mar 13, 2016

@flowersinthesand flowersinthesand changed the title from Handle typed arrays as binary to Accept typed arrays in send method Mar 13, 2016

@flowersinthesand flowersinthesand self-assigned this Feb 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment