Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept typed arrays in send method #10

Closed
flowersinthesand opened this issue Mar 13, 2016 · 0 comments
Closed

Accept typed arrays in send method #10

flowersinthesand opened this issue Mar 13, 2016 · 0 comments
Assignees
@flowersinthesand
Milestone
1.0.0-Beta1

Comments

@flowersinthesand
Copy link
Member

As a result of cettia/cettia-javascript-client#9, it turns out that it is better to accept typed arrays as well as Buffer to handle binary data. That means, when determining if the given object is binary, ArrayBuffer.isView as well as Buffer.isBuffer should be used.

But, transport's binary event should accept Buffer only.
@flowersinthesand flowersinthesand added this to the 1.0.0-Beta1 milestone Mar 13, 2016
@flowersinthesand flowersinthesand changed the title Handle typed arrays as binary Accept typed arrays in send method Mar 13, 2016
flowersinthesand added a commit that referenced this issue Mar 13, 2016
@flowersinthesand
Don't run tests on Node 0.10 where ArrayBuffer.isView is not supported
51f50fe 
Refs #10
@flowersinthesand flowersinthesand self-assigned this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flowersinthesand flowersinthesand

Labels
None yet
Projects
None yet
Milestone
1.0.0-Beta1
Development

No branches or pull requests
1 participant
@flowersinthesand