Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWebSocket transport doesn't fire close event when a connection fails #3
Comments
flowersinthesand
added this to the 1.0.0-Alpha2 milestone
May 25, 2015
flowersinthesand
closed this
in
44a404c
May 25, 2015
added a commit
that referenced
this issue
May 25, 2015
added a commit
that referenced
this issue
May 27, 2015
flowersinthesand
self-assigned this
Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
flowersinthesand commentedMay 25, 2015
ws 0.7.2's implementation emulates The WebSocket API by W3C but its behavior on connection fail is little different. Typically, browsers fire
errorevent and thencloseevent but ws module fireserrorevent only.Whatever the reason, it's right that transport should fire
closeevent if it couldn't establish a connection. FYI, the above issue is reported to websockets/ws#505