Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket transport doesn't fire close event when a connection fails #3

Closed
flowersinthesand opened this issue May 25, 2015 · 0 comments
Closed

WebSocket transport doesn't fire close event when a connection fails #3

flowersinthesand opened this issue May 25, 2015 · 0 comments
Assignees
@flowersinthesand
Milestone
1.0.0-Alpha2

Comments

@flowersinthesand
Copy link
Member

ws 0.7.2's implementation emulates The WebSocket API by W3C but its behavior on connection fail is little different. Typically, browsers fire error event and then close event but ws module fires error event only.

Whatever the reason, it's right that transport should fire close event if it couldn't establish a connection. FYI, the above issue is reported to websockets/ws#505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flowersinthesand flowersinthesand

Labels
None yet
Projects
None yet
Milestone
1.0.0-Alpha2
Development

No branches or pull requests
1 participant
@flowersinthesand