Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket transport doesn't work with URI whose authority has no trailing slash and query is not empty #6

Closed
flowersinthesand opened this issue May 30, 2015 · 0 comments
Assignees
Milestone

Comments

@flowersinthesand
Copy link
Member

@flowersinthesand flowersinthesand commented May 30, 2015

That means ws://localhost:1234 and ws://localhost:1234/?foo=bar do work fine but ws://localhost:1234?foo=bar doesn't work. I don't think URI's authority should have a trailing slash regardless of query string but am not quite sure in terms of specification. (However even Node.js's url module doesn't add a trailing slash to authority when formatting a url object.)

Anyway, ws 0.7.2 requires to do that and we need to work around it. The issue is reported to websockets/ws#258 and websockets/ws#386

@flowersinthesand flowersinthesand added this to the 1.0.0-Alpha2 milestone May 30, 2015
@flowersinthesand flowersinthesand self-assigned this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.