Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Unit tests for #285, #303 and #330 #368

Open
wants to merge 1,807 commits into
from

Conversation

Projects
None yet
8 participants
Contributor

sjurba commented Aug 15, 2012

The pull request is split in 2 commits:

  • Refactoring existing code (not mine)
    • Moved a static block to the constructor of CeylonTokenColorer
    • Moved some constants from AbstratRefactoring to RefactorMenuItems as this is the only location they are used.
  • Tests for #285, #303 and #330
    • This also adds a test-src source folder and JUnit 4 to the build path.

This pull request replaces #344 with a much cleaner history.

The tests are POJO JUnit tests and does not use any Eclipse specific plugin test code, which is the reason why the refactoring was required.

Member

ikasiuk commented on 419aaa3 Jul 21, 2012

The modified background color doesn't work well for me: the normal tool tip colors on my system are white text on black background. Now the background color is brighter but the text is still white. So I can hardly read anything. I would prefer if the colors continued to use the system settings, as they did before. After all the whole rest of the eclipse GUI also uses the system's look and feel.

Owner

gavinking replied Jul 21, 2012

The modified background color doesn't work well for me: the normal tool tip colors on my system are white text on black background.

Really? White on black!? What OS is this? Surely all the little icons also look totally broken in that color scheme?

Now the background color is brighter but the text is still white. So I can hardly read anything.

Ah well I guess I can easily force the text color to black. Does that work for you?

Member

ikasiuk replied Jul 21, 2012

Really? White on black!? What OS is this? Surely all the little icons also look totally broken in that color scheme?

Ubuntu 12.04 with the standard look and feel called "Ambiance". The tool tips are black and slightly translucent, with white text. The translucency doesn't seem to work for these big hover help things in Eclipse, but apart from that they nicely use the system colors.

Some icons don't look so nice because they seem to use antialiasing assuming a bright background. But they are not totally broken.

Ah well I guess I can easily force the text color to black. Does that work for you?

At least that surely would be better than what I have now.

gavinking and others added some commits Jul 21, 2012

@gavinking gavinking rip out obsolete stuff d30749f
@gavinking gavinking consistent look for laels 6c479ce
@gavinking gavinking settable color for outline+hierarchy popups d8e022e
@gavinking gavinking oops, fix color preference 34a2b71
@gavinking gavinking oops aca1e86
@gavinking gavinking #337 auto-insert imports for proposals from imported modules 36fbabb
@gavinking gavinking fixes for #337 119e6ec
@gavinking gavinking minor 13dd2f3
@gavinking gavinking clean up Proposal hierarchy 4728eac
@gavinking gavinking auto-add imports in Extract Value / Extract Function c661e41
@gavinking gavinking auto-add import for some quick fixes
fix "add parameter" for methods
bdc021e
@gavinking gavinking fix a couple of bugs with create proposals, and auto-add imports 8af6bac
@gavinking gavinking auto-add imports in Change type edfae7e
@gavinking gavinking updated jar 76edacb
@gavinking gavinking fix #332 intersection Change Type proposals 3b11330
@gavinking gavinking handle qualified expressions 87f5932
@thradec thradec Issue #322 : Outline view - hide non-shared members cd40624
@thradec thradec Issue #322 : Outline view - collapse all bada21c
@gavinking gavinking Merge pull request #339 from thradec/issue322
Issue #322 : Outline view
18e30b9
@gavinking gavinking fix outline sort de2e561
@gavinking gavinking fix Export Module wizard 7dd04fd
@thradec thradec Issue #322 : Outline view - expand all c9054a4
@gavinking gavinking Merge pull request #340 from thradec/issue322
Issue #322 : Outline view - expand all
c632807
@gavinking gavinking make outline view selection follow editor caret d135aa8
@gavinking gavinking Merge branch 'master' of github.com:ceylon/ceylon-ide-eclipse 9ed2d0f
@gavinking gavinking change the new module wizard icons to something more consistent 93a1d0b
@gavinking gavinking fix outline auto-expanding behavior 0450741
@gavinking gavinking does this fix a problem with the output folder path?
(as reported by zlp in mailing list)
914eab1
@gavinking gavinking clean imports 425aa71
@gavinking gavinking use SubMonitor dbe74fc
@gavinking gavinking properly filter the member list in the doc hover 528a86b
@gavinking gavinking minor changes to work more like java outline view 54cf6a3
@gavinking gavinking Add Ceylon Explorer by huge copy/paste from JDT 09f7b38
@gavinking gavinking present packages as children of modules in flat explorer presentation c702cd9
@gavinking gavinking update jar 1174ade
@gavinking gavinking line breaks 42519b0
@gavinking gavinking update jar for #90 99c1aa2
@thradec thradec Issue #90 : Add ... quick fix for sequence arg 6bbfcb2
@gavinking gavinking Merge pull request #341 from thradec/issue90
Issue #90 : Add ... quick fix for sequence arg
c4ada5a
@gavinking gavinking improve description of quick fix d661b2b
@gavinking gavinking qualified see links 44247fb
@gavinking gavinking propose quick fix for any Iterable, not just sequences 158f2f0
@gavinking gavinking Add field for entering module version in New Module wizard for #211 5aca36f
@gavinking gavinking oops 4714321
@gavinking gavinking add "refines" to doc hover + change icon for see links 122baae
@gavinking gavinking #335 supertype hierarchy c97195d
@gavinking gavinking organize imports a10d25e
@gavinking gavinking minor 71fb35a
@gavinking gavinking top left icons in hierarchy and outline view + refactoring 84dc040
@gavinking gavinking cache images 3e42a15
@gavinking gavinking 3-mode hierarchy popup 3d5bc70
@gavinking gavinking fix refinement hierarchy 51a1abf
@gavinking gavinking snappier title bde6caf
@sjurba sjurba Fix for #303 Convert if-else to then-else e3697a4
@sjurba sjurba Merge remote-tracking branch 'upstream/master' into fix_303 d1b835d
@gavinking gavinking fix for path handling on windows, as reported by zlp 1befbca
@gavinking gavinking improve Make default quick fix fa8df35
@gavinking gavinking improve algorithm for finding refined dec e264232
@gavinking gavinking Merge pull request #343 from sjurba/fix_303
Fix for #303 Convert if-else to then-else
c05f212
@gavinking gavinking misc cleanup 7d42c34
@gavinking gavinking update jar d897f42
@gavinking gavinking build hierarchy model with busy cursor b03295f
@gavinking gavinking remove obsolete iface a255239
@gavinking gavinking renaming 72141f3
@gavinking gavinking reimplement Hierarchy popup to use hierarchy nodes instead of maps
(should be much more memory-efficient)
7f115c2
@gavinking gavinking indicate that a member refines multiple things in hierarchy popup 8ab643b
@gavinking gavinking indicate that interfaces are not displayed in hierarchy popup 374465c
@gavinking gavinking Select Enclosing (shift-ctrl-up) acc3b93
@sjurba sjurba Fix for #303 - Disabled is, exists and nonempty expressions because of
lacking type narrowing for then expression.
dac1a60
@gavinking gavinking Merge pull request #345 from sjurba/fix_303
Fix for #303 - Disabled is, exists and nonempty expressions because of
81d5973
@gavinking gavinking add code popup + improve colors + persist popup bounds 96dd5d8
@gavinking gavinking various minor changes c05cbec
@gavinking gavinking fix annotation hover size 0178847
@gavinking gavinking add icon to code popup 41c91cd
@gavinking gavinking shortcut to open editor from source view 9430a6b

gavinking and others added some commits Jul 30, 2012

@gavinking gavinking cross-refs between perspectives 96846bf
@gavinking gavinking ups! 1c16947
@gavinking gavinking links from console stack traces to Ceylon code db98e25
@gavinking gavinking be smarter about guessing what method to run 62200c3
@gavinking gavinking properly report backend errors 578040f
@gavinking gavinking now unnecessary 47c2b79
@gavinking gavinking probably unnecessary now d0830e4
@gavinking gavinking minor 065a4d8
@gavinking gavinking fix #159 generate type constraints for refined member 6258b18
@gavinking gavinking update jar e8f3c26
@gavinking gavinking squash npe 71328e1
@gavinking gavinking fix two bugs in new project wiz 8440be3
@gavinking gavinking auto-add import elements to imported packages from clean imports dfa020a
@gavinking gavinking pre-scan modules in job to make autocomplete pop up faster ea5ca6c
@gavinking gavinking roll back because of deadlocks 37340df
@gavinking gavinking improve perspective view locs 58e89bf
@gavinking gavinking update jar 76b17fa
@gavinking gavinking handle type occurrences f0336a5
@gavinking gavinking update jar 339a072
@gavinking gavinking fix for change to model API 7a82daf
@gavinking gavinking squash npes 64a2b06
@gavinking gavinking support for "throws" annotation in doc hover 70f2d82
@gavinking gavinking auto-add imports from any available package 2c5116a
@gavinking gavinking clean up whole package 3b496f3
@gavinking gavinking auto-import param types in create proposals 8732833
@gavinking gavinking squash npe 384fd43
@gavinking gavinking very basic auto-import impl for Create in New Unit proposals e420cee
David Festal Update README.md 86846e3
@gavinking gavinking cleanup annotation/marker handling 6b2da0d
@gavinking gavinking Merge branch 'master' of https://github.com/ceylon/ceylon-ide-eclipse 9a5a7b5
@quintesse quintesse Removed part about IMP and added Juno to possible Eclipse versions c0f8342
@gavinking gavinking more consistency in handling marker annotations a06a08e
@gavinking gavinking Merge branch 'master' of https://github.com/ceylon/ceylon-ide-eclipse 0a580d1
@gavinking gavinking reduce a couple of delays because I don't really want to wait that long 991ec70
@gavinking gavinking rename 10bacb5
@gavinking gavinking comment out unused stuff f2905f1
@gavinking gavinking add Terminate Statement to menu + minor refactoring ea720bf
@gavinking gavinking first impl of TerminateStatement 31a620b
@gavinking gavinking Reimplementation of Terminate Statement with awesome bracket-closer 41ec1a5
@gavinking gavinking update typechecker jar 06bcd48
@gavinking gavinking refresh occurrence annotations after change/reparse 148df43
@gavinking gavinking enable wildcards in filter patterns 34a5214
@gavinking gavinking comment 5108522
@gavinking gavinking Fix #291, pop up import proposals in a selection dialog 75b5e5d
@thradec thradec Issue #359: Add constraint proposal on type argument is not assignable 258c471
@thradec thradec fix. after rebase 817271b
@gavinking gavinking slight cleanup of DocumentProvider stuff f9c0796
@gavinking gavinking added special aggregated Open Type dialog to ceylon perspective f609081
@gavinking gavinking changed key binding for open ceylon declaration to not conflict with
Java editor keybinding, and to be more ergonomic
1f1aac4
@gavinking gavinking unused import 55fd3b7
@gavinking gavinking Merge pull request #362 from thradec/issue359
Issue #359: Add constraint proposal on type argument is not assignable
6da4fa4
@gavinking gavinking Merge branch 'master' of https://github.com/ceylon/ceylon-ide-eclipse 523e753
@gavinking gavinking syntax highlighting in proposals fixes #361 6adbb8e
@gavinking gavinking update jar fbf6559
@gavinking gavinking try to deal with some interactions between content proposals
and occurrence marking / annotation creation where the content proposal
popup kept loosing focus
b1676ee
@gavinking gavinking a couple of fixes to member proposals d6ec68f
@gavinking gavinking feedback via window progress bar when building completions/hierarchy 5510891
@gavinking gavinking oops, put the exception handling back in 0e90077
@gavinking gavinking minor 9800a61
@gavinking gavinking syntax highlighting in quick fixes/assists 44b519f
@gavinking gavinking update jar d66ff45
@gavinking gavinking minor 3dfddf6
@thradec thradec Issue #359: fix. given T satisfies Comparable<T> & Comparable<T> aeae5ab
Owner

gavinking commented on aeae5ab Aug 3, 2012

Thanks, @thradec :)

Owner

FroMage commented on ffaab14 Aug 4, 2012

And me, and everyone else who would think WTF: a bug in the backend AND in the IDE? ;) Thanks!

Owner

FroMage commented Oct 18, 2012

@gavinking @davidfestal why didn't we merge this?

Member

davidfestal commented Oct 18, 2012

We will use (but already have now thanks to Max) a specific test framework for the Eclipse application.
So the question is : do we also want to use simple JUnit tests, along with the eclipse-specific testing framework ?

Owner

gavinking commented Oct 18, 2012

I didn't merge it because I asked @maxandersen and @davidfestal to think about this in the context of our whole approach to testing—i.e. I avoided responsibility.

Owner

gavinking commented Sep 17, 2013

@davidfestal here are some tests that @sjurba wrote ages ago. Since we now have a test suite, we should look into including these ones.

Member

davidfestal commented Sep 17, 2013

Sure.

@davidfestal davidfestal was assigned Sep 17, 2013

@davidfestal davidfestal modified the milestone: Ceylon 1.2, Ceylon 1.1 Feb 11, 2014

@bjansen bjansen modified the milestone: 1.3.1, 1.3.2, 1.4 Dec 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment