Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

missing SharedAnnotations on native implementations #408

Open
gavinking opened this Issue · 9 comments

4 participants

@gavinking
Owner

There are lots of places missing @ceylon.language.SharedAnnotation$annotation$!

@tombentley
Collaborator

We can't do this right now (indeed Gavin's above commit got reverted) because we can't use the Java versions of those annotations on Java declarations which are being compiled at the same time as they ceylon annotation declarations themselves. In other words this is blocked by ceylon/ceylon-compiler#470.

@FroMage
Owner

Even if we implemented it in our compiler, Eclipse's JDT would not let us edit it without lots of red.

@tombentley tombentley modified the milestone: 1.2, 1.1
@tombentley
Collaborator

Reassigning to 1.2 then, unless @gavinking pipes up with how the missing annotations cause an actual bug.

@gavinking
Owner
@gavinking
Owner

For example, if I try to retrieve all the shared classes in the language module, I won't get some of them.

@FroMage
Owner

This is something we may be able to fix in the model loader if required.

@tombentley
Collaborator

@FroMage I'm not sure this is easily fixed in the model loader, since the metamodel runtime doesn't use the model loader to find declarations with a given annotation -- it uses the Java annotation reflection API directly.

@tombentley tombentley referenced this issue in ceylon/ceylon-spec
Closed

add Throwable and Error #916

@quintesse
Collaborator

Can't we just create a Java version of this file until the moment ceylon/ceylon-compiler#470 is implemented?

@tombentley
Collaborator

Not 1.1, sadly.

@tombentley tombentley modified the milestone: 1.1.5, 1.1
@gavinking gavinking modified the milestone: 1.3, 1.2
@tombentley tombentley referenced this issue from a commit
@tombentley tombentley Issue #408: Allow duplicated ids when registering references for dese…
…rialization, ignoring all but the first reference made.
30c40f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.