Showing loading indicator while fetching current trends.

cezarsa · Feb 17, 2011 · 185b1ed · 185b1ed
1 parent 8522c12
commit 185b1ed
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 25 deletions.
diff --git a/background.html b/background.html
@@ -929,12 +929,12 @@
   },
 
   retrieveTrendingTopics: function(callback, woeid) {
-	this.twitterBackend.trendingTopics(function(success, userData) {
-	  if(success) {
-	    callback( userData[0] );
-	  }
-	}, woeid);
-  },
+    this.twitterBackend.trendingTopics(function(success, userData) {
+      if(success) {
+        callback(userData[0]);
+      }
+    }, woeid);
+  }
 };
 
 /* Clean up old versions mess */

diff --git a/popup.html b/popup.html
@@ -1546,29 +1546,29 @@
 }
 
 function loadTrends() {
-  //var _this = this;
-  //$("#loading").show();
-  currentTTLocale = eval('(' + OptionsBackend.get('trending_topics_woeid')+ ')');
+  var currentTTLocale = eval('(' + OptionsBackend.get('trending_topics_woeid')+ ')');
+
+  $("#trending_topics").actionMenu({
+    loading: 'img/loading.gif',
+    parentContainer: '#workspace'
+  });
 
   tweetManager.retrieveTrendingTopics(function(userData) {
-    trendings = [];
-    for( var i=0; i < userData.trends.length; ++i )
-      trendings.push( userData.trends[i].name );
-
-    var myActions = [];
-    $.each( trendings, function(i, myName) {
-      myActions.push({
-        name: myName,
-        action: function(event) {
-          TimelineTab.addNewSearchTab(myName, event.isAlternateClick);
-        },
-      });
-    });
+    var actions = [];
+    for(var i = 0, len = userData.trends.length; i < len; ++i) {
+      (function(trendName) {
+        actions.push({
+          name: trendName,
+          action: function(event) {
+            TimelineTab.addNewSearchTab(trendName, event.isAlternateClick);
+          }
+        });
+      })(userData.trends[i].name);
+    }
     $("#trending_topics").actionMenu({
-      actions: myActions, 
-      parentContainer: '#workspace'
+      actions: actions
     });
-  }, currentTTLocale.woeid );
+  }, currentTTLocale.woeid);
 }
 
 function prepareTimelines() {