New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapping libxml2 modulemap for Xcode 9.3 #83

Merged
merged 5 commits into from Apr 3, 2018

Conversation

Projects
None yet
5 participants
@banjun
Copy link
Contributor

banjun commented Apr 3, 2018

Fixes #77.
Although the issue has been referenced by several PRs, this PR patches in another way, that does remove libxml2/module.modulemap from Fuzi.

The modulemap is no longer needed because Xcode 9.3 has the modulemap in its SDK. (It's not included in Xcode 9.2 and before.)
Accordingly this also removes SWIFT_INCLUDE_PATHS a.k.a. Import Paths as it no longer exists, and adds -lxml2 to the project as README says at the Install Manually section.

@banjun banjun referenced this pull request Apr 3, 2018

Closed

Build fails with xcode 9.3 (Beta) #77

1 of 3 tasks complete
@SuperY

This comment has been minimized.

Copy link

SuperY commented Apr 3, 2018

Need fix tvOS build params in travis file.

@SuperY

This comment has been minimized.

Copy link

SuperY commented Apr 3, 2018

This is my way:

Change ".swift-version" file --> 4.1

Update ".travis.yml"
osx_image: xcode9.3beta
- DESTINATION="platform=tvOS Simulator,name=Apple TV 4K" SDK="appletvsimulator" ACTION="test"

@banjun

This comment has been minimized.

Copy link
Contributor

banjun commented Apr 3, 2018

@SuperY Thank you pointing out!

@cezheng

This comment has been minimized.

Copy link
Owner

cezheng commented Apr 3, 2018

This is purely awesome!

Extra thanks for updating the Japanese/Chinese README 😄

@cezheng cezheng merged commit 2be94c5 into cezheng:master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@banjun banjun deleted the banjun:fix-redef-module-libxml2-xcode9.3 branch Apr 3, 2018

@skathiresan

This comment has been minimized.

Copy link

skathiresan commented Apr 3, 2018

@banjun @cezheng Shouldn't we also need to update the pod version?

@drosenstark

This comment has been minimized.

Copy link

drosenstark commented Apr 4, 2018

Will this new version work in Xcode 9.2 without the libxml2/module.modulemap? I've got a complex situation with this dependency and need to tease out what is what. Thanks!

@banjun

This comment has been minimized.

Copy link
Contributor

banjun commented Apr 4, 2018

@drosenstark No. It completely depends on Xcode 9.3. You should use Fuzi 2.0.1 when you build with Xcode 9.2.

@cezheng

This comment has been minimized.

Copy link
Owner

cezheng commented Apr 5, 2018

Correct. The latest version only supports latest Xcode. Use old versions of Fuzi for old versions Xcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment