Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A basic direct form I FIR filter and tests #4

Merged
merged 3 commits into from Jun 3, 2018

Conversation

sriyash25
Copy link
Contributor

made requested changes in previous PR. Extra files: fda/fir_test.py which is the class used to pass parameters and test.txt has random values of x which are passed for simulation.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 46.851%

Totals Coverage Status
Change from base Build 7: 2.3%
Covered Lines: 372
Relevant Lines: 794

💛 - Coveralls

@cfelton cfelton changed the title Gsoc2 A basic direct form I FIR filter and tests Jun 3, 2018
@cfelton
Copy link
Owner

cfelton commented Jun 3, 2018

I am going to merge this pull-request, note something in the future will move / change, e..g the fir_test module should evolve to the fda.fir or move to an experimental, test, or something directory.

@cfelton cfelton merged commit 67cf339 into cfelton:master Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants