Skip to content

Fixed how rpm packages install selinux policy #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fixed how rpm packages install selinux policy #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packaging/cfengine-community/cfengine-community.spec.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ Requires: coreutils
Recommends: gzip
%endif

# we require selinux-policy package version that matches or exceeds our build system version
# this guarantees that our compiled selinux policy will work.
# We add a recommends for the selinux-policy package version that matches or exceeds our build system version.
# This increases the likelihood that our compiled selinux policy will work.
# By making this a weak dependency we allow the package to install on systems with an older selinux-policy version.
%if %{?rhel}%{!?rhel:0} >= 8
Requires: selinux-policy >= @@SELINUX_POLICY_VERSION@@
Recommends: selinux-policy >= @@SELINUX_POLICY_VERSION@@
%endif

AutoReqProv: no
Expand Down Expand Up @@ -147,6 +148,7 @@ done
%prefix/selinux/cfengine-enterprise.pp
%prefix/selinux/cfengine-enterprise.te
%prefix/selinux/cfengine-enterprise.fc
%prefix/selinux/label-binaries-unconfined.sh
%endif

# Globally installed configs, scripts
Expand Down
9 changes: 6 additions & 3 deletions packaging/cfengine-nova-hub/cfengine-nova-hub.spec.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ Recommends: gzip
Requires(pre): /usr/sbin/useradd, /usr/sbin/userdel, /usr/bin/getent
Requires(post): /usr/sbin/usermod, /bin/sed

# we require selinux-policy package version that matches or exceeds our build system version
# this guarantees that our compiled selinux policy will work.
# We add a recommends for the selinux-policy package version that matches or exceeds our build system version.
# This increases the likelihood that our compiled selinux policy will work.
# By making this a weak dependency we allow the package to install on systems with an older selinux-policy version.
%if %{?rhel}%{!?rhel:0} >= 8
Requires: selinux-policy >= @@SELINUX_POLICY_VERSION@@
Recommends: selinux-policy >= @@SELINUX_POLICY_VERSION@@
%endif


# we don't bundle OpenSSL on RHEL 8 (and newer in the future)
%if %{?rhel}%{!?rhel:0} == 8
Requires: libssl.so.1.1()(64bit) libssl.so.1.1(OPENSSL_1_1_0)(64bit) libssl.so.1.1(OPENSSL_1_1_1)(64bit)
Expand Down Expand Up @@ -413,6 +415,7 @@ exit 0
%prefix/selinux/cfengine-enterprise.pp
%prefix/selinux/cfengine-enterprise.te
%prefix/selinux/cfengine-enterprise.fc
%prefix/selinux/label-binaries-unconfined.sh
%endif

# Documentation
Expand Down
8 changes: 5 additions & 3 deletions packaging/cfengine-nova/cfengine-nova.spec.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ Requires: coreutils
Recommends: gzip
%endif

# we require selinux-policy package version that matches or exceeds our build system version
# this guarantees that our compiled selinux policy will work.
# We add a recommends for the selinux-policy package version that matches or exceeds our build system version.
# This increases the likelihood that our compiled selinux policy will work.
# By making this a weak dependency we allow the package to install on systems with an older selinux-policy version.
%if %{?rhel}%{!?rhel:0} >= 8
Requires: selinux-policy >= @@SELINUX_POLICY_VERSION@@
Recommends: selinux-policy >= @@SELINUX_POLICY_VERSION@@
%endif

# we don't bundle OpenSSL on RHEL 8 (and newer in the future)
Expand Down Expand Up @@ -173,6 +174,7 @@ exit 0
%prefix/selinux/cfengine-enterprise.pp
%prefix/selinux/cfengine-enterprise.te
%prefix/selinux/cfengine-enterprise.fc
%prefix/selinux/label-binaries-unconfined.sh
%endif

# Globally installed configs, scripts
Expand Down
16 changes: 5 additions & 11 deletions packaging/common/cfengine-hub/postinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,11 @@ then
test -x /usr/sbin/restorecon || cf_console echo "warning! selinuxenabled exists and returns 0 but restorecon not found"
fi
if ! cf_console semodule -n -i "$PREFIX/selinux/cfengine-enterprise.pp"; then
cf_console echo "warning! semodule import failed, examine /var/log/CFE*log and \
consider installing selinux-policy-devel package and \
rebuilding policy with: \
\
cd $PREFIX/selinux \
make -f /usr/share/selinux/devel/Makefile -j1 \
semodule -n -i $PREFIX/selinux/cfengine-enterprise.pp \
\
and then restarting services with \
\
systemctl restart cfengine3"
cf_console echo "warning! semodule import failed, as a fallback all binaries in $PREFIX will be labeled bin_t aka unconfined. \
The semodule import failure should be examined in /var/log/CFE*log and reported so that properly confined CFEngine can be setup."
if ! "$PREFIX"/selinux/label-binaries-unconfined.sh "$PREFIX"; then
cf_console echo "warning! fallback to label all binaries unconfined has failed. CFEngine may not properly operate with selinux set to enforcing."
fi
fi
if /usr/sbin/selinuxenabled; then
/usr/sbin/load_policy
Expand Down
16 changes: 5 additions & 11 deletions packaging/common/cfengine-non-hub/postinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,17 +127,11 @@ then

fi
if ! cf_console semodule -n -i "$PREFIX/selinux/cfengine-enterprise.pp"; then
cf_console echo "warning! semodule import failed, examine /var/log/CFE*log and \
consider installing selinux-policy-devel package and \
rebuilding policy with: \
\
cd $PREFIX/selinux \
make -f /usr/share/selinux/devel/Makefile -j1 \
semodule -n -i $PREFIX/selinux/cfengine-enterprise.pp \
\
and then restarting services with \
\
systemctl restart cfengine3"
cf_console echo "warning! semodule import failed, as a fallback all binaries in $PREFIX will be labeled bin_t aka unconfined. \
The semodule import failure should be examined in /var/log/CFE*log and reported so that properly confined CFEngine can be setup."
if ! "$PREFIX"/selinux/label-binaries-unconfined.sh "$PREFIX"; then
cf_console echo "warning! fallback to label all binaries unconfined has failed. CFEngine may not properly operate with selinux set to enforcing."
fi
fi
if /usr/sbin/selinuxenabled; then
/usr/sbin/load_policy
Expand Down