Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM: Query for dereferencing a pointer argument without NULL-comparison #3631

Merged
merged 1 commit into from May 2, 2019

Conversation

2 participants
@olehermanse
Copy link
Member

commented Apr 30, 2019

This query has 6000 alerts currently, but I still think it will be valuable for new Pull Requests.

LGTM: Query for dereferencing a pointer argument without NULL-comparison
Changelog: None
Ticket: None
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>

@olehermanse olehermanse added the lgtm label Apr 30, 2019

@olehermanse olehermanse requested review from vpodzime and craigcomstock Apr 30, 2019

@vpodzime
Copy link
Contributor

left a comment

Looks good to me. Very nice, actually!

@olehermanse olehermanse merged commit c2eadb5 into cfengine:master May 2, 2019

5 of 6 checks passed

LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing cd2ec6a...8f47497
Details
codecov/project 60.92% (+<.01%) compared to cd2ec6a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@olehermanse olehermanse deleted the olehermanse:lgtm_null_check branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.