Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM: Unified all boolean return type checking #3644

Merged
merged 1 commit into from May 3, 2019

Conversation

2 participants
@olehermanse
Copy link
Member

commented May 3, 2019

New query uses a recursive predicate to check if something is
boolean. This detects some nested problems (inside !() and
()?():()). It is more readable and maintainable than the
previous 3 queries. Also removed the exception for int
functions, this will give us 600 more alerts to fix.

LGTM: Unified all boolean return type checking
New query uses a recursive predicate to check if something is
boolean. This detects some nested problems (inside `!()` and
`()?():()`). It is more readable and maintainable than the
previous 3 queries. Also removed the exception for `int`
functions, this will give us 600 more alerts to fix.

Changelog: None
Ticket: None
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>

@olehermanse olehermanse requested a review from vpodzime May 3, 2019

@olehermanse olehermanse added the lgtm label May 3, 2019

@vpodzime
Copy link
Contributor

left a comment

Much nicer than before. 😍

@olehermanse olehermanse merged commit 699b472 into cfengine:master May 3, 2019

5 of 6 checks passed

LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing c3d8b31...6283c89
Details
codecov/project 60.95% (+0.01%) compared to c3d8b31
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@olehermanse olehermanse deleted the olehermanse:lgtm_bool_query branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.