crontabs and common paths bundle #14

neilhwatson · 2012-02-28T22:11:58Z

Crontabs is self explanatory. The paths bundle I'd like to be a community
effort to catalog the paths to commonly called commands.

zzamboni · 2012-02-28T22:50:22Z

system/cronjobs/cronjobs.cf

+
+	files:
+
+		"${g.nhw_crontabs}/${user}"


This should be modified to use paths.crontabs instead of g.nhw_crontabs.

zzamboni · 2012-02-28T23:26:51Z

Hi Neil - thanks for the submission! I think the paths bundle is an excellent idea.

I have made a couple of comments on some lines.

nickanderson · 2012-02-29T01:39:00Z

I like the paths idea too. Maybe its just me and my brain wanting to limit scope, does anyone else find it easier to read a commit that is just a single sketch?

zzamboni · 2012-02-29T01:42:01Z

That's the idea in general - one sketch per pull request. In this case I think it made sense to bundle them because one uses the other.

--Diego

On Feb 28, 2012, at 7:39 PM, Nick Andersonreply@reply.github.com wrote:

I like the paths idea too. Maybe its just me and my brain wanting to limit scope, does anyone else find it easier to read a commit that is just a single sketch?

Reply to this email directly or view it on GitHub:
#14 (comment)

neilhwatson · 2012-02-29T02:02:23Z

Made changes.

nickanderson · 2012-02-29T02:04:46Z

On 02/28/2012 08:02 PM, Neil H Watson wrote:

Made changes.

Did you push your changes to your fork? I still see the g.nhw_crontabs
references in the pull request.

Nick Anderson nick@cmdln.org

nickanderson · 2012-02-29T02:25:29Z

system/cronjobs/cronjobs.cf

@@ -0,0 +1,34 @@
+bundle agent cronjobs(user, jobs) {


Should this one perhaps be named cronjobs_add since it just appends if not found?

nickanderson · 2012-02-29T03:13:56Z

neil what do you think about the bundle name change from cronjobs to cronjobs_add since it appends if not found. I think that would leave logical namespace for something like cronjobs_delete and other patterns for dealing with cronjobs, perhaps cron_d style related.

nickanderson · 2012-02-29T03:30:04Z

I was thinking sketchname of cronjobs like you had but the only bundle you submitted in that sketch was also named cronjobs. I thought maybe just rename that bundle and we can add more cronjob related bundles to the sketch am curious what others think though before you keep making changes on my whims :)

zzamboni · 2012-02-29T03:56:17Z

I agree - I think the sketch should be named cronjobs (or just cron), with the bundle names indicative of their function (e.g. cron_add, cron_delete, etc.)

nickanderson · 2012-02-29T03:56:25Z

system/paths/metadata.txt

@@ -0,0 +1,3 @@
+author: Neil H Watson, neil@watson-wilson.ca
+ostype: Any UNIX


Are these metadata values for ostype, tested, and cfengine_version supposed to be valid cfengine classes?
Which ones are required?

Should there be a comma between the name and email address?

I ask because I am thinking ahead to what the not yet finished tooling is going to want to expect and it would be nice to have a tool that could be used to validate a submission

In this case, ostype should be unix, which is a hard class defined by CFEngine on any Unix-style operating system. The author should preferably be Name <email@address.com>.

Indeed the idea is that we'll have a tool that can validate and submit sketches, and also one to install them.

Which if any fields are required?

neilhwatson · 2012-03-01T02:21:14Z

I have one other large sketch to add. Is it better to wait for this pull to complete and then start a new one?

nickanderson · 2012-03-01T02:29:24Z

Your in the same spot I was, your clone is progressing at a faster pace than upstream. I don't know what the official stance is, but it is probably best to get your stuff on a feature branch.
I found diasporas workflow to be pretty helpful, its concise at least.
https://github.com/diaspora/diaspora/wiki/Git-Workflow
Diego also pointed me to this which is a good read.
http://nvie.com/posts/a-successful-git-branching-model/

I see one more thing that needs to be addressed in the submission,
There is supposed to be a cf file matching the sketch name, so if you just rename system/cron/cronjobs_add.cf to system/cron/cron.cf and leave the bundlename as is. Then maybe diego can merge the pull request.

Then you should update your clone from upstream, and create a feature branch off of it where you can add your new sketch and submit a pull request for that.

I just had to work through doing that yesterday so if you need help let me know.

zzamboni · 2012-03-01T02:57:13Z

Hi Neil,

The best is to start a new branch for each sketch, then you can submit multiple pull requests simultaneously.

--Diego

On Feb 29, 2012, at 8:21 PM, Neil H Watson reply@reply.github.com wrote:

I have one other large sketch to add. Is it better to wait for this pull to complete and then start a new one?

Reply to this email directly or view it on GitHub:
#14 (comment)

nickanderson · 2012-03-01T02:58:57Z

On 02/29/2012 08:57 PM, Diego Zamboni wrote:

Hi Neil,

The best is to start a new branch for each sketch, then you can
submit multiple pull requests simultaneously.

If you branch before your changes are merged and do a pull request on
that branch that pull request will include your other sketches.

Nick Anderson nick@cmdln.org

nickanderson · 2012-03-01T03:27:35Z

I think these two sketches look good, anyone see any issues with merging?

nickanderson · 2012-03-01T03:28:20Z

system/cron/metadata.txt

@@ -0,0 +1,3 @@
+author: Neil H Watson <neil@watson-wilson.ca>
+ostype: Linux, Solaris 10, AIX
+tested: Debian 6


oops, this should be a valid class name probably debian_6 ?

zzamboni · 2012-03-01T06:34:09Z

That's why you never develop on your master branch - that way every branch starts off with the "clean" state of the master branch, without any other changes, and they can be merged independently.

On Feb 29, 2012, at 8:58 PM, Nick Anderson wrote:

If you branch before your changes are merged and do a pull request on
that branch that pull request will include your other sketches.

crontabs and common paths bundle.

bundles.cf: rm_rf and rm_rf_depth bundles: add docs and port to 3.5

Remove references to cf-report

Added more content instructing how to write promises

Added a basic crontab bundle. Started a common bundle for system paths.

fd3d4a0

zzamboni reviewed Feb 28, 2012
View reviewed changes

Made changes as suggested.

c414014

nickanderson reviewed Feb 29, 2012
View reviewed changes

Fixed classes

a964b11

Changed sketch name.

27b9268

nickanderson reviewed Feb 29, 2012
View reviewed changes

Changed meta data and renamed sketch

6ee02d9

One more time. :(

710a23a

nickanderson reviewed Mar 1, 2012
View reviewed changes

zzamboni added a commit that referenced this pull request Mar 1, 2012

Merge pull request #14 from neilhwatson/master

da6242c

crontabs and common paths bundle.

zzamboni merged commit da6242c into cfengine:master Mar 1, 2012

tzz added a commit to tzz/design-center that referenced this pull request Jan 21, 2014

Merge pull request cfengine#14 from tzz/master

46a4a02

bundles.cf: rm_rf and rm_rf_depth bundles: add docs and port to 3.5

zzamboni added a commit to tzz/design-center that referenced this pull request Jun 1, 2014

Merge pull request cfengine#14 from nickanderson/cleanup/cf-report

6c8b93d

Remove references to cf-report

tzz pushed a commit to tzz/design-center that referenced this pull request Jun 1, 2014

Merge pull request cfengine#14 from TekHus/basic-guide-policy-writing

77898ab

Added more content instructing how to write promises

dichen001 mentioned this pull request Jun 28, 2016

Summary of the 20 issues in Herbsleb's 2014 FSE paper. dichen001/Paper-Reading#6

Open

crontabs and common paths bundle #14

crontabs and common paths bundle #14

neilhwatson commented Feb 28, 2012

zzamboni Feb 28, 2012

zzamboni commented Feb 28, 2012

nickanderson commented Feb 29, 2012

zzamboni commented Feb 29, 2012

neilhwatson commented Feb 29, 2012

nickanderson commented Feb 29, 2012

nickanderson Feb 29, 2012

nickanderson commented Feb 29, 2012

nickanderson commented Feb 29, 2012

zzamboni commented Feb 29, 2012

nickanderson Feb 29, 2012

zzamboni Feb 29, 2012

nickanderson Feb 29, 2012

neilhwatson commented Mar 1, 2012

nickanderson commented Mar 1, 2012

zzamboni commented Mar 1, 2012

nickanderson commented Mar 1, 2012

nickanderson commented Mar 1, 2012

nickanderson Mar 1, 2012

zzamboni commented Mar 1, 2012

		@@ -0,0 +1,3 @@
		author: Neil H Watson, neil@watson-wilson.ca
		ostype: Any UNIX

crontabs and common paths bundle #14

crontabs and common paths bundle #14

Conversation

neilhwatson commented Feb 28, 2012

zzamboni Feb 28, 2012

Choose a reason for hiding this comment

zzamboni commented Feb 28, 2012

nickanderson commented Feb 29, 2012

zzamboni commented Feb 29, 2012

neilhwatson commented Feb 29, 2012

nickanderson commented Feb 29, 2012

nickanderson Feb 29, 2012

Choose a reason for hiding this comment

nickanderson commented Feb 29, 2012

nickanderson commented Feb 29, 2012

zzamboni commented Feb 29, 2012

nickanderson Feb 29, 2012

Choose a reason for hiding this comment

zzamboni Feb 29, 2012

Choose a reason for hiding this comment

nickanderson Feb 29, 2012

Choose a reason for hiding this comment

neilhwatson commented Mar 1, 2012

nickanderson commented Mar 1, 2012

zzamboni commented Mar 1, 2012

nickanderson commented Mar 1, 2012

nickanderson commented Mar 1, 2012

nickanderson Mar 1, 2012

Choose a reason for hiding this comment

zzamboni commented Mar 1, 2012