ENT-6536: Shortened Inventory OS attribute to be more readable #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
force-pushed
the
inventory
branch
from
20621bf
to
029c009
Compare
|
Created a follow-up ticket: https://tracker.mender.io/browse/ENT-6658 |
This is the main string used in many places, including MP UI, pie charts, reports etc. We want it to be the shortest, most human intuitive and readable way, so: * Ubuntu 18 * Debian 9 * CentOS 6 * RHEL 7 * SUSE 15 * Windows 2016 We use the old implementation (based on LSB) as a fall back, but prefer data from os-release, and in some cases we have overrides for specific platform versions to ensure consistency, even when the OS maintainers don't agree with each other or even their past selves. Even if it isn't perfect everywhere, always, that is okay, it's supposed to be a shortened pretty string. Ticket: ENT-6536 Changelog: Title Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
olehermanse
force-pushed
the
inventory
branch
from
029c009
to
0de9488
Compare
|
@cf-bottom jenkins, please. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/6013/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-6013/ |
|
@nickanderson ready for review. |
nickanderson
approved these changes
Jan 14, 2021
|
I am still not 100% convinced that this should be in the MPF, but not enough doubts to reject it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on:
OS strings are as shown ^