New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Masterfiles travis failures #932
Conversation
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@cfengine.com>
This change looks good, but it's not enough. When Another change is needed, maybe in core cf-net binary could be optional. |
@jimis cf-net doesn't exist in 3.10. So I think core is correct as is? cf-net exists in master and 3.11, not 3.10 or 3.7 |
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@cfengine.com>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@cfengine.com>
@nickanderson @jimis So the problem here is that we're testing 3.10 package with 3.11 tests / testall. My suggestion is to comment out the latest/master test case for now, and re-enable it when 3.11 includes cf-net. We can run into the same error if we add new features with tests, but we also kind of want to test master with latest, even though they can be quite different. |
Well at least I find the actual versions easier to read than lts/oldlts. We do need want to make sure that 3.11 MPF works on 3.10, and 3.7 binaries (because of upgrade) |
This is a good compromise. We should remember to uncomment the top section when 3.11 is out, in both 3.11 and master branches. |
This should be picked into 3.11 3.10 and 3.7 branches? |
@nickanderson The cf-net commit should only be in 3.11.x and master. The others you can try to cherry pick back. |
@jimis Maybe this fixes it?