Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Masterfiles travis failures #932

Merged
merged 3 commits into from Jun 16, 2017
Merged

Conversation

olehermanse
Copy link
Member

@jimis Maybe this fixes it?

Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@cfengine.com>
@jimis
Copy link
Contributor

jimis commented Jun 16, 2017

This change looks good, but it's not enough. When testall invokes testall --bindir then cf-net binary fails is not found and that one fails. This happens because we install packages of 3.10 and 3.7 here that don't have cf-net at all.

Another change is needed, maybe in core cf-net binary could be optional.

@olehermanse
Copy link
Member Author

@jimis cf-net doesn't exist in 3.10. So I think core is correct as is? cf-net exists in master and 3.11, not 3.10 or 3.7

Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@cfengine.com>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@cfengine.com>
@olehermanse olehermanse changed the title Add cf-net to testall Fix Masterfiles travis failures Jun 16, 2017
@olehermanse
Copy link
Member Author

@nickanderson @jimis So the problem here is that we're testing 3.10 package with 3.11 tests / testall. My suggestion is to comment out the latest/master test case for now, and re-enable it when 3.11 includes cf-net. We can run into the same error if we add new features with tests, but we also kind of want to test master with latest, even though they can be quite different.

@nickanderson
Copy link
Member

Well at least I find the actual versions easier to read than lts/oldlts.

We do need want to make sure that 3.11 MPF works on 3.10, and 3.7 binaries (because of upgrade)

@jimis
Copy link
Contributor

jimis commented Jun 16, 2017

This is a good compromise. We should remember to uncomment the top section when 3.11 is out, in both 3.11 and master branches.

@nickanderson
Copy link
Member

This should be picked into 3.11 3.10 and 3.7 branches?

@nickanderson nickanderson merged commit 2dbd5c7 into cfengine:master Jun 16, 2017
@olehermanse
Copy link
Member Author

@nickanderson The cf-net commit should only be in 3.11.x and master. The others you can try to cherry pick back.

@olehermanse olehermanse deleted the cfnet branch December 1, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants