Skip to content

add filter to validate CITATION.cff using Docker image#47

Merged
fdiblen merged 7 commits into
mainfrom
validcff-filter
Feb 2, 2022
Merged

add filter to validate CITATION.cff using Docker image#47
fdiblen merged 7 commits into
mainfrom
validcff-filter

Conversation

@fdiblen

@fdiblen fdiblen commented Feb 1, 2022

Copy link
Copy Markdown
Member

Description

Related issues:

Instructions to review the pull request

  • Make a GitHub Access token here https://github.com/settings/tokens

    • Make sure you copy it when it appears on screen, because you can't see it again. You can reset it, though.
  • export GITHUB_TOKEN as an environment variable with the token above

  • install Node >= 14

    cd $(mktemp -d --tmpdir cffbot-XXXXXX)
    git clone https://github.com/cffbots/filtering .
    git checkout <this-branch>
    npm install
    node query.mjs
    

Sample filtered list

urls: [
'https://github.com/e-mental-health/data-processing',
'https://github.com/NLeSC/python-template',
'https://github.com/NLeSC/case-law-app',
'https://github.com/NLeSC/eEcology-Annotation-WS',
'https://github.com/NLeSC/eEcology-script-wrapper',
'https://github.com/NLeSC/eEcology-SMS-reciever',
'https://github.com/NLeSC/esibayes'
]

@fdiblen fdiblen marked this pull request as ready for review February 1, 2022 17:10
Comment thread query.mjs Outdated

@jspaaks jspaaks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Comment thread query.mjs Outdated
Comment thread query.mjs Outdated
Comment thread query.mjs Outdated
fdiblen and others added 3 commits February 2, 2022 10:38
Co-authored-by: Abel Siqueira <abel.s.siqueira@gmail.com>
Co-authored-by: Abel Siqueira <abel.s.siqueira@gmail.com>
Co-authored-by: Abel Siqueira <abel.s.siqueira@gmail.com>

@abelsiqueira abelsiqueira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM. Tested locally and it returned 17 repos.

@fdiblen

fdiblen commented Feb 2, 2022

Copy link
Copy Markdown
Member Author

Thank you @jspaaks and @abelsiqueira for reviewing!

@fdiblen fdiblen merged commit 513ba5e into main Feb 2, 2022
@fdiblen fdiblen deleted the validcff-filter branch February 2, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants