New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ConfigurationSources for system properties and environment varia… #146

Merged
merged 3 commits into from Apr 8, 2016

Conversation

Projects
None yet
2 participants
@majkiw
Contributor

majkiw commented Apr 8, 2016

…bles

public void shouldReturnManuallyDefinedKeysAfterReload() throws Exception {
assertThat(source.getConfiguration(new DefaultEnvironment())).doesNotContainKey("reloaded.property");
System.setProperty("reloaded.property", "defined");
assertThat(source.getConfiguration(new DefaultEnvironment())).containsKey("reloaded.property");

This comment has been minimized.

@majkiw

majkiw Apr 8, 2016

Contributor

It's actually not clear if the contract of getConfiguration() requires it to be stable unless reload() is called.
InMemoryConfigurationSource seems to only change when reload() is called, however FilesConfigurationSource would reload on every getConfiguration() call.

@majkiw

This comment has been minimized.

Contributor

majkiw commented Apr 8, 2016

This intents to solve #128

@norbertpotocki norbertpotocki added this to the v.4.3.0 milestone Apr 8, 2016

@norbertpotocki

This comment has been minimized.

Member

norbertpotocki commented Apr 8, 2016

👍 👏

@norbertpotocki norbertpotocki merged commit 526f47f into cfg4j:master Apr 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment