Remove initialized=false if a configuration fails to load #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 this fixes an issue for me as well |
|
Thanks for contributing this @akonsand! |
norbertpotocki
pushed a commit
that referenced
this pull request
Jul 12, 2017
* Remove initialized=false if a configuration fails to load
norbertpotocki
added a commit
that referenced
this pull request
Jul 12, 2017
|
Hi, great framework. :) But we have the same problem with GitConfigurationSource. |
|
Hi @LostOblivion. This issue has been fixed in release 4.4.1. Let me know if you're still running into it. |
|
@norbertpotocki Is it fixed for GitConfigurationSource, or just for ConsulConfigurationSource? We still get the error with 4.4.1 when using GitConfigurationSource. Perhaps this line is the problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the key value fetch fails, due to consul being down for a few seconds, or the connection failing, in which case this flag is set to false. If it is set to false, the getConfiguration() method keeps on throwing IllegalStateExceptions, bringing our entire application down.
I think the purpose of the initialized flag was to to prevent getConfiguration() being called before init() completed, and hence setting the flag here is not needed.