Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autoformatting of splice (;) shorthand #8

Closed
CFiggers opened this issue Oct 15, 2023 · 1 comment
Closed

Fix autoformatting of splice (;) shorthand #8

CFiggers opened this issue Oct 15, 2023 · 1 comment

Comments

@CFiggers
Copy link
Owner

Currently, having ; anywhere in a form causes the autoformatter to choke.

Looks like ; is not handled in parser/core.cljs—look at

vscode-janet-plus-plus/src/cljs-lib/src/pez_rewrite_clj/parser/core.cljs

Line 166 in eeecbb0

;; (identical? c \;) parse-comment

Will probably need a new node type added as well (Clojure doesn't have an equivalent to splice)
CFiggers added a commit that referenced this issue Oct 16, 2023
@CFiggers
Handle splice and unquote format-on-type
1f84850 
Addresses Fix autoformatting of splice (`;`) shorthand #8
@CFiggers
Copy link
Owner Author

Delivered with #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CFiggers