New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Install' flag does not work with multiple selections. #20

Closed
admiralbumblebee opened this Issue Jul 12, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@admiralbumblebee

admiralbumblebee commented Jul 12, 2017

Select multiple packages in the browser, then select 'actions->install' (above versions) to flag them for installation.

Only the first item in the selection is flagged.

'Install/update selection' does work, however the menu labelling is confusing.

@cfillion

This comment has been minimized.

Owner

cfillion commented Jul 12, 2017

This is the normal behavior. The difference between per-package and selection-wide actions is shown in the user guide at https://github.com/cfillion/reapack/wiki#actions.

Do you have an idea for a better labeling?

@admiralbumblebee

This comment has been minimized.

admiralbumblebee commented Jul 12, 2017

Is there any reason why there's a way to install 1 package when multiple are selected?

It seems to me that the menu-items should correlate to what is selected, single or multi-selection.

Am I perhaps missing some functionality here that would make that sub-optimal?

@cfillion

This comment has been minimized.

Owner

cfillion commented Jul 15, 2017

It adds flexibility and speed (especially when right-clicking). The per-package actions show details and options (eg. pick-which-version and show documentation) on the selected package under the mouse cursor that would otherwise not be available without first discarding the selection (and possibly redoing it afterward, which I find annoying).

@admiralbumblebee

This comment has been minimized.

admiralbumblebee commented Jul 15, 2017

The best suggestion I have is some better indication that then second 'install' menu option is for the item under the cursor.

Perhaps something such as "Install only v1.1" would better indicate that a single package is being acted upon.

@cfillion

This comment has been minimized.

Owner

cfillion commented Jul 15, 2017

I can do it like this using a submenu:

Idea 1

cfillion added a commit that referenced this issue Jul 17, 2017

browser: always show selection actions in the context menu
and never in the Actions button's menu

(related to issue #20)

@cfillion cfillion closed this in 4d3da65 Jul 17, 2017

cfillion added a commit that referenced this issue Jul 17, 2017

@admiralbumblebee

This comment has been minimized.

admiralbumblebee commented Jul 18, 2017

Excellent solution. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment