Many Updates!!! #1

Merged
merged 3 commits into from Feb 13, 2012

Projects

None yet

2 participants

Hello Ray,

I updated your original file heavily and would like you to pull it and test it. I think you will like what I added. Some things are as follows:

  • set whether or not to write logs with a simple boolean setting
  • set requested_uri based on server rewrite you may me using (added IIRF for IIS, IIS7 UrlRewrite and the 2 fallbacks for mod_rewrite)
  • ability to send 404 or temp image if file does not exists
  • on error an image stating file could not be created is served back to the user
  • ability to request original image by adding ?original=1 to URL
  • ability to override cookie values and request specific dimensions as follows:
    ?width=100 : resizes image to a width of 100
    ?height=100 : resizes image to a height of 100
    ?width=100&height=100 : scales an image to fit into 100x100
    ?width=100&height=100&crop=1 : scales an image and then crops to the specified dimensions

Well hope you pull it and notify people of the update if you like it.

Thank you,
Giancarlo Gomez
South Florida CFUG Co-Manager
http://cfug-sfl.org/

GiancarloGomez added some commits Dec 29, 2011
@GiancarloGomez GiancarloGomez updates - added error checking with image generation, ability to requ…
…est original image as well as custom sizes by width, height, width and height scaled to fit or cropped
2a56dd0
@GiancarloGomez GiancarloGomez fixed a forced error I forgot before commit ca90026

The additional update, shortly after making my request was a forced error I forgot to take off while I was testing.

@GiancarloGomez GiancarloGomez Fixed working with cookie in process - added back ifStructKeyExists a…
…nd applied the send mobile_first fallback at end of if statement
5994ead

One more update Ray - on the processing call it never had a fallback to the mobilefirst setting if cookie did not exists - also added back check for cookie existence. One more thing - in your original one the watch_cache did not work but now it does. That was another one of the updates I did last night

Owner

I have to be honest. I use Github - but I don't quite know yet how to handle this process. How do I look at your code, and then once I approve it, make it trunk?

Hello Ray,

This page explains the process of sending and pulling requests.

My fork is at https://github.com/fusedev/Adaptive-Images

Thank you,
Giancarlo Gomez
FUSEDEVELOPMENTS
C: 305.610.9428
http://www.fusedevelopments.com
http://blog.fusedevelopments.com

On Dec 30, 2011, at 7:36 PM, Raymond Camden wrote:

I have to be honest. I use Github - but I don't quite know yet how to handle this process. How do I look at your code, and then once I approve it, make it trunk?


Reply to this email directly or view it on GitHub:
#1 (comment)

@cfjedimaster cfjedimaster merged commit 1960888 into cfjedimaster:master Feb 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment