Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and expansions identified while building Filing Landing page #96

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

meissadia
Copy link
Contributor

Closes #95

Changes

  • [Component] Well - Make the headerLevel prop optional
  • [Component] Divider - created
  • [Component] Link - Expand supported variations and create stories
  • [Component] Button - support styling as a link

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit d0b6576
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/649dcc37f62ec10008344713
😎 Deploy Preview https://deploy-preview-96--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Support styling any link with the list links
 dotted bottom border
- cleanup classnames
- Expand supported variations
- Create stories
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Our icon spacing is a little off in the links but that's an issue with the Icon component unrelated to this PR.

src/components/Link/Link.stories.tsx Outdated Show resolved Hide resolved
src/components/Link/Link.stories.tsx Outdated Show resolved Hide resolved
meissadia and others added 2 commits June 29, 2023 12:23
Co-authored-by: Chris Contolini <contolini@users.noreply.github.com>
Co-authored-by: Chris Contolini <contolini@users.noreply.github.com>
@meissadia meissadia merged commit 377ca41 into main Jun 29, 2023
5 checks passed
@meissadia meissadia deleted the 95-filing-fixes branch June 29, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements from Filing Landing page
2 participants