New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generation of test vectors #196
Conversation
Nice! I will take a more careful look in the next few days. To be clear: the JSON wouldn't go into the document, right? (Of course, we can provide test vector files to be downloaded and mechanically processed.) So probably we will also want a script to turn the JSON structures into whatever format will actually go into the appendix of the document. (Or have I missed it, and that's already here?) |
No, only ascii. JSON files are intended to be available at an external repo.
Now it supports both ascii and json formats. |
This branch has been rebased including the Python3 updates. |
I know that I still need to review this. I'm sorry for the very long delay. I should have time this week. Just to double check: The Sage9/Python3 version generates the same test vectors as the Sage8/Python2 version, right? |
3d8a9db
to
b84043b
Compare
The SHA512 suites for {curve/edwards}25519 are now included in Sage scripts. |
I rebased this on top of master because the diff interface was very confused :) |
Looks good to me. I re-ran test vector generation on my machine (sage9/python3) and got the same files back out. Just a few very small things.
I assume once #212 lands and we update the code to the new suites we'll generate new test vectors, but it doesn't hurt to have these in the repo history anyway, IMO.
I did a quick cursory scan -- looks good! (Riad having run them gives me confidence it's good to go.)
Co-Authored-By: Riad S. Wahby <kwantam@gmail.com>
Co-Authored-By: Riad S. Wahby <kwantam@gmail.com>
It is re-based on top of #189 and #201 .
JSON test vectors for matching compatible implementations.
Example: