Implement linked-list-cycle-ii #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://leetcode.com/problems/linked-list-cycle-ii time: 16ms time-rank: 21.04% time-complexity: O(N) space: 10MB space-rank: 9.36% space-complexity: O(N) Fixes #228 Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
https://leetcode.com/problems/linked-list-cycle-ii time: 4ms time-rank: 98.90% time-complexity: O(N) space: 7.8MB space-rank: 89.71% space-complexity: O(1) This solution adds no extra space but destroys the input. While the cost of checking if a node is visited is still O(1), this solution is faster than an unordered_set<LinkedList*> lookup because no hashing is performed, values are likely still in cache, and it is simply a const comparison. Fixes #228 Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
cfriedt
force-pushed
the
linked-list-cycle-ii
branch
from
88d2c52 to
77a8eeb
Compare
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 97.20% 97.22% +0.02%
==========================================
Files 96 98 +2
Lines 2538 2557 +19
==========================================
+ Hits 2467 2486 +19
Misses 71 71
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/linked-list-cycle-ii
time: 4ms
time-rank: 98.90%
time-complexity: O(N)
space: 7.8MB
space-rank: 89.71%
space-complexity: O(1)
This solution adds no extra space but destroys the input. While the cost of checking if a node is visited is still O(1), this solution is faster than an unordered_set<LinkedList*> lookup because no hashing is performed, values are likely still in cache, and it is simply a const comparison.
Fixes #228