Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/wheels/events/onerror/cfmlerror.cfm inappropriately stripping error info #1091

Closed
adamcameron opened this issue Aug 16, 2021 · 1 comment · Fixed by #1120
Closed

/wheels/events/onerror/cfmlerror.cfm inappropriately stripping error info #1091

adamcameron opened this issue Aug 16, 2021 · 1 comment · Fixed by #1120
Labels

Comments

@adamcameron
Copy link

Copy/paste from CFWheels google group:

Anyone know why this logic (in /wheels/events/onerror/cfmlerror.cfm) is there:

<cfif local.template Does Not Contain "wheels" AND FindOneOf("/", local.template) IS NOT 0>
Line #local.tagContext[local.pos].line# in #local.template#

Why would CFWheels actively remove lines from the error context? It's not like errors don't occur in Wheels's code, or Wheels's code doesn't contribute to an erroring situation. What is being gained by taking that information out?

A real world case in point here. I just got this alert:

Error: key [COLUMN] doesn't exist
Location: Line 123 in /path/to/file/in/our/app

That error came from CFWheels's wheels/model/adapters/Base.cfc file, a fact Wheels has unhelpfully stripped from the error reporting.

However for someone who doesn't know the mungling being done, they're gonna be looking for a stray reference to COLUMN in their code @ line 123.

Also... what if my filename / path actually has "wheels" in it?

This feature seems "unhelpful" to me on first blush, but I might be missing something?

I'm using 1.4.x but do not expect any bugfixes to that; it's the same issue with 2.x though.

@bpamiri
Copy link
Collaborator

bpamiri commented May 11, 2022

@adamcameron This should be fixed and is in the bleeding edge release for now. You can check it out by doing a box install cfwheels@be and drop the wheels folder into an active project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants