New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sendFile() to support ram:// resources #566

Closed
neokoenig opened this Issue Nov 13, 2015 · 5 comments

Comments

2 participants
@neokoenig
Member

neokoenig commented Nov 13, 2015

There's a fairly easy change which can be made to sendFile() to allow it to send ram based resources;
Essentially, you just check for ram:// in the args and then bypass the physical file check.

I've got the code for this, but before I add it, just wanted to poll whether
a) should this be classed as a new feature and be saved for 2.0?
b) should we also check for S3:// resources (and indeed, with sendFile, is that even possible?) Afraid I don't use S3:// much, so don't really have much to test against.

Being able to do sendFile("ram://foo.pdf") is actually really useful....

@perdjurner

This comment has been minimized.

Contributor

perdjurner commented Nov 13, 2015

a) that would be a new feature in my opinion.
b) no, that sounds more like plugin material.

@neokoenig

This comment has been minimized.

Member

neokoenig commented Nov 13, 2015

It's going to have to be 2.0 where we're dropping CF8, as ram:// isn't supported on that, so you couldn't create a passing test for it. I'll write a couple of tests and pop it in master if there are no objections.

@perdjurner

This comment has been minimized.

Contributor

perdjurner commented Nov 13, 2015

👍

@neokoenig neokoenig added the docs label Nov 13, 2015

@neokoenig neokoenig added this to the 2.0.0 milestone Nov 13, 2015

neokoenig added a commit that referenced this issue Nov 13, 2015

@neokoenig

This comment has been minimized.

Member

neokoenig commented Nov 13, 2015

Code in master + a couple of tests. Leaving open to document

@perdjurner perdjurner modified the milestone: 2.0.0 Mar 30, 2016

@neokoenig

This comment has been minimized.

Member

neokoenig commented Apr 28, 2017

Closing. Documented in https://docs.cfwheels.org/v2.0/docs/sending-files and a code example in the core

@neokoenig neokoenig closed this Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment