Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validatesConfirmationOf() isn't case sensitive #918

Closed
neokoenig opened this issue Feb 6, 2019 · 1 comment
Closed

validatesConfirmationOf() isn't case sensitive #918

neokoenig opened this issue Feb 6, 2019 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@neokoenig
Copy link
Member

@neokoenig neokoenig commented Feb 6, 2019

Oddly, validatesConfirmationOf() doesn't seem to do a case sensitive check.
Since 99% of the time, you're checking that passwords match, it really should. Either that or we should add a case sensitivity flag (as emails would still be valid for instance)

Test:

// Add this to: wheels/tests/models/validations/standard_validations.cfc

	function test_validatesConfirmationOf_invalid_case() {
		user.password = "HamsterJelly";
		user.passwordConfirmation = "hamsterjelly";
		user.validatesConfirmationOf(property="password");
		assert('!user.valid()');
	}
@neokoenig neokoenig added the bug label Feb 6, 2019
@neokoenig neokoenig self-assigned this Feb 19, 2019
@neokoenig neokoenig added this to the 2.1.0 milestone Feb 19, 2019
@neokoenig

This comment has been minimized.

Copy link
Member Author

@neokoenig neokoenig commented Feb 19, 2019

Fixed in 5697a7f

@neokoenig neokoenig closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.