Confirm argument on linkTo() doesn't work #94

Closed
andybellenie opened this Issue Oct 3, 2012 · 12 comments

Comments

4 participants
Contributor

andybellenie commented Oct 3, 2012

This is something to do with the HTML5 stuff. It's been an issue in the provides plugin for a while. Any ideas?

@ghost ghost assigned raulriera Oct 3, 2012

Contributor

andybellenie commented Oct 4, 2012

Raul, do you have any ideas on this? I think it's related to remote form helpers

rip747 commented Oct 11, 2012

If this is the hardcoded jaavascript stuff, pull it from the repo and make it a plugin. I don't any more Javascript wackiness in core.

rip747 commented Oct 12, 2012

i was looking at this. when passing in the confirm argument, it generates a data-confirm attribute on the anchor. this is to be used with the rails.js that can be found at:

https://github.com/rails/jquery-ujs/blob/master/src/rails.js

i think the only thing to do is before releasing is to document this so people know they will have to download it.

Contributor

andybellenie commented Oct 12, 2012

Wheels should be JS agnostic, I'll remove it.

rip747 commented Oct 13, 2012

seems like we already have a copy of the js file for this vendored in the repo:

https://github.com/cfwheels/cfwheels/blob/new-master/wheels/vendor/ajax-adapters/wheels.jquery.js

Contributor

andybellenie commented Jan 17, 2013

I've reconsidered here and am happy to include the file, but the vendor folder is not currently accessible past the url-rewriting. Should we move the file into the JS folder? Or add a rule to the rewriting?

rip747 commented Jan 17, 2013

I would put the file in the vendor directory and hust have the dev copy the file to the js folder if they want to enable it

Contributor

andybellenie commented Jan 17, 2013

The confirm argument doesn't work without this file so I think we should try and make it work out of the box if possible. What about automatically including it using cfhtmlhead?

@ghost ghost assigned rip747 May 16, 2013

rip747 commented Sep 16, 2013

the only way I can see that working is if we write the cfhtmlhead whenever a call to linkto using the confirm argument is used. this presents a problem since we will need some sort of global variable to check to make sure that we haven't included it more then once.

Contributor

andybellenie commented Sep 16, 2013

How about if we put it in /js and then add a javascriptTag() call to layout.cfm?

rip747 commented Sep 16, 2013

marvelous idea :)

On Mon, Sep 16, 2013 at 10:23 AM, Andy Bellenie notifications@github.comwrote:

How about if we put it in /js and then add a javascriptTag() call to
layout.cfm?


Reply to this email directly or view it on GitHubhttps://github.com/cfwheels/cfwheels/issues/94#issuecomment-24513376
.

rip747 commented Jan 1, 2014

after thinking about this. its better to follow how the rails team does it: let the dev download and install the js file themselves. I've already included documentation on how to do this.

hopefully at some point we'll have a package manager some day to take care of this sort of stuff for us.

@rip747 rip747 closed this Jan 1, 2014

@perdjurner perdjurner modified the milestones: 1.3.0, 1.2.0 Jul 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment