New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for JSON type in Mysql and also seperating the long types so that length validation isn't an issue #759

Merged
merged 3 commits into from Apr 12, 2017

Conversation

3 participants
@joelstobart

joelstobart commented Apr 6, 2017

Add JSON mysql type and also set the rv for text to cf_sql_longvarchar
Add the cf_SQL_LONGVARCHAR and CF_SQL_LONGNVARCHAR to return "text" rather than string

Joel Stobart
Add JSON mysql type and also set the rv for text to cf_sql_longvarchar
Add the cf_SQL_LONGVARCHAR and CF_SQL_LONGNVARCHAR to return "text" rather than string
local.rv = "cf_sql_varchar";
break;
case "json": case "text": case "mediumtext": case "longtext": case "tinytext":
loc.rv = "cf_sql_longvarchar";

This comment has been minimized.

@chrisdpeters

chrisdpeters Apr 6, 2017

Contributor

For CFWheels 2.0, this should be using the local scope, not the now-defunct vared loc struct that we were using before.

This comment has been minimized.

@joelstobart

joelstobart Apr 8, 2017

Sorry - I'm running a version older than this. So the syntax was differrent...

@chrisdpeters

This comment has been minimized.

Contributor

chrisdpeters commented Apr 6, 2017

@joelstobart Thank you for this. Can you fix the one issue that I pointed out?

Joel Stobart added some commits Apr 8, 2017

Joel Stobart
Merge branch 'master' of https://github.com/cfwheels/cfwheels into Fi…
…xes_for_JSON

* 'master' of https://github.com/cfwheels/cfwheels:
  Scoping.
  Scoping.
  Scoping.
  Scoping.
  Scoping.
  Minor syntax fix - built in functions should be PascalCase
  Fix tests involving namespace mapper
@joelstobart

This comment has been minimized.

joelstobart commented Apr 8, 2017

FYI: Test results

Lucee 5.1.0.34

Status:
Passed

Duration
00:00:11

Packages
286

Tests
1361

Failures
0

Errors
0

@perdjurner perdjurner merged commit 762c2eb into cfwheels:master Apr 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joelstobart joelstobart deleted the joelstobart:Fixes_for_JSON branch Apr 12, 2017

@perdjurner

This comment has been minimized.

Contributor

perdjurner commented Apr 12, 2017

Thank you.

Note: I moved "tinytext" back to map to "cf_sql_varchar".

@joelstobart joelstobart restored the joelstobart:Fixes_for_JSON branch Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment