Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Relaxed type signature for mergeSources #25
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
bfops
Jul 20, 2014
Collaborator
LGTM. I haven't looked at this with a super-pessimistic eye, but it's been on my mind for a few weeks now. As far as I can tell, if you can get it to typecheck, it should work fine. Thanks!
LGTM. I haven't looked at this with a super-pessimistic eye, but it's been on my mind for a few weeks now. As far as I can tell, if you can get it to typecheck, it should work fine. Thanks! |
added a commit
to dmcclean/stm-conduit
that referenced
this issue
Jul 20, 2014
added a commit
to dmcclean/stm-conduit
that referenced
this issue
Jul 20, 2014
dmcclean
referenced this issue
Jul 20, 2014
Merged
Generalized type of mergeSources and (>=<) per issue #25. #26
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Ignore the one with hash a2a49ca, I forgot to make a branch before I pushed that one. I think it would probably make sense to perform a similar surgery to |
dmcclean commentedJul 20, 2014
The current type of
(>=<)
andmergeSources
requires theSource
s being merged to use a monad of the formResourceT m
for somem
. For example:If possible, it would be great if this signature could be relaxed to a type like this one:
There may be some reason why this can't work, in which case I apologize for raising the issue. It does seem that it was once this way until version 0.4, so perhaps it was discovered to be unworkable.
If it is unworkable, you are aware of a workaround, and have time to explain it briefly that would be awesome. Thanks for the great library.