Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC Authentication not possible (Android 4.x) #7497

Open
mirabilos opened this issue Apr 14, 2019 · 19 comments

Comments

@mirabilos
Copy link

@mirabilos mirabilos commented Apr 14, 2019

Detailed steps causing the problem:
  • start c:geo
  • see it cannot login to OC.DE
  • try to reauthenticate via Settings → Services
  • see it fail
Actual behavior after performing these steps:

it fails

Expected behavior after performing these steps:

it should login to OC.DE

Version of c:geo used:

NB 2019-04-13 375874c

Is the problem reproducible for you?

Yes

System information:

can do if needed

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 15, 2019

Thanks for your report.
Can you explain in more detail, what failure happens?
Does your browser open to present the login page of oc.de?

What Android version are you using (system information could be indeed helpful here).

@mirabilos

This comment has been minimized.

Copy link
Author

@mirabilos mirabilos commented Apr 15, 2019

@fusselwolf

This comment has been minimized.

Copy link

@fusselwolf fusselwolf commented Apr 23, 2019

Hi Lars,
i've just exact the same issue on Blackberry Z10 with OS 10,3,3.21,37.
c:geo-release is 20190416.
oc.nl and oc.uk are cinnecting normal!

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 23, 2019

As its working normal for me I assume some device or device browser related issue.
As no browser app selection dialog is displayed, one try could be to remove your current default browser from being used as default (in device app manager) and try authorizing again.

After clicking "Authorize" the browser should open...then we can try to find out more clues or if the problem is connected with a certain browser.

Other options:

  • Did you ever try to delete the login information completely by long pressing the "Authorize again" in c:geo?
  • Did you try to logout in your phone browser and then start the process in c:geo to authorize?
@fusselwolf

This comment has been minimized.

Copy link

@fusselwolf fusselwolf commented Apr 24, 2019

Hi Lars,
the behavior with diffent browsers was the same. Since Rel. 2019.04.16 no button "uthorize again" is displayed, the other options where both unsuccessful.
Then i deleted c:geo and installed first 2019.02.23 --> all ok! Then updated to 2019.04.04 --> ok.
After this i updated to the current 2019.04.16 --> "OC.DE (...) Anmeldung fehlgeschlagen", while GC and OC.UK displays "Anmeldung ok"

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 24, 2019

Since Rel. 2019.04.16 no button "uthorize again" is displayed, the other options where both unsuccessful.

There should be (in german: "cgeo neu autorisieren") the button if you long press it it resets the account information.

Then i deleted c:geo and installed first 2019.02.23 --> all ok! Then updated to 2019.04.04 --> ok.
After this i updated to the current 2019.04.16 --> "OC.DE (...) Anmeldung fehlgeschlagen", while GC and OC.UK displays "Anmeldung ok"

Thanks for testing this. I will take a look into the changes..really strange.

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 24, 2019

Between version 2019.04.04 and 2019.04.16 I do only see one suspicious change which could IMHO be related: 9dde821

@samueltardieu @UniQP
Could it be, that the OKHTTP introduced such kind of bug in authorization to OC?

@samueltardieu

This comment has been minimized.

Copy link
Member

@samueltardieu samueltardieu commented Apr 24, 2019

Absolutely, hence my comment #7453 (comment)

@mirabilos

This comment has been minimized.

Copy link
Author

@mirabilos mirabilos commented Apr 24, 2019

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 24, 2019

So it seems the issue was caused by our upgrade of okhttp libraries, however it is strange, that his only affects some devices and only some/one oc plattform.

I think, this needs to be investigated a bit deeper.

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 24, 2019

Up to now we have it only on Android 4.4.x (kitkat) and Blackberry (whatever Android version is below).

@Lineflyer Lineflyer removed the Unverified label Apr 24, 2019
@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 24, 2019

I can maybe reproduce the problem on a 4.4.2 device, however the ADB driver is not working, so cant get a trace now.

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 25, 2019

Some other field reports now, all with Android 4.4.x

I can still not get ADB interface working on my devices....so if someone can reproduce with an 4.4 emulator and get a stacktrace, this would be appreciated.

@mirabilos

This comment has been minimized.

Copy link
Author

@mirabilos mirabilos commented Apr 25, 2019

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 25, 2019

@mirabilos
Yes, activate debug log in c:geo Settings - System
Then run the oc.de auth procedure and capture the logcat please.

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 25, 2019

Note:
The debug log might contain some keys which are personal information.
You might therefore want to replace them by placeholder and/or send the log to support@cgeo.org rather than posting it here.

@Lineflyer Lineflyer changed the title OC Login nicht möglich, cannot reauthenticate either OC Authentication not possible (Android 4.x) Apr 27, 2019
@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 27, 2019

Finally got ADB runing on my Android 4.4.2 phone:

14:31:17.977 Debug cgeo 4810  [OkHttp] GET https://www.opencaching.de/okapi/services/oauth/request_token?oauth_callback=callback%3A%2F%2Fwww.cgeo.org%2Fopencaching.de%2F&oauth_consumer_key=REMOVED&oauth_nonce=REMOVED&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1556368275&oauth_version=1.0&oauth_signature=REMOVED%3D
14:31:18.085 Warning cgeo 4810  [OkHttp] Failure (62 ms) GET https://www.opencaching.de/okapi/services/oauth/request_token?oauth_callback=callback%3A%2F%2Fwww.cgeo.org%2Fopencaching.de%2F&oauth_consumer_key=REMOVED&oauth_nonce=REMOVED&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1556368275&oauth_version=1.0&oauth_signature=REMOVED%3D (javax.net.ssl.SSLHandshakeException: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x63525988: Failure in SSL library, usually a protocol error
14:31:18.085 Warning cgeo 4810  error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure (external/openssl/ssl/s23_clnt.c:741 0x5da11004:0x00000000))
14:31:18.085 Error cgeo 4810  [network--9] requestToken: cannot get token

I assume it is because the device does not support sslv3 ?!

Strange enough that for other OC-sites the token request works normal.
Is this caused by a change on our side (as discussed above) or on OC.de?

@Lineflyer

This comment has been minimized.

Copy link
Member

@Lineflyer Lineflyer commented Apr 27, 2019

Addition:
I tested it on the same device but using release 2019.04.04 (before the OKHTTP library change) and its working towards OC.de.

So I assume a change in that library combined with a more strict security setting on OC.de.

@mirabilos

This comment has been minimized.

Copy link
Author

@mirabilos mirabilos commented Apr 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.