Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dask to_allele_counts #266

Merged
merged 4 commits into from May 31, 2019

Conversation

Projects
None yet
3 participants
@hardingnj
Copy link
Collaborator

commented May 30, 2019

chunks was not being passed to the method

also needed to specify drop_ and new_ axis

Nick Harding
Fix for dask to_allele_counts
chunks was not being passed to the method

also needed to specify drop_ and new_ axis
@pep8speaks

This comment has been minimized.

Copy link

commented May 30, 2019

Hello @hardingnj! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-31 15:37:07 UTC

@hardingnj hardingnj requested a review from alimanfoo May 30, 2019

@alimanfoo
Copy link
Contributor

left a comment

Thanks Nick, all looks good. Please could you fix the PEP8 issues, then should be good to merge.

alimanfoo added some commits May 31, 2019

@alimanfoo
Copy link
Contributor

left a comment

Went ahead and fixed the line length issues. Also added a release note.

@alimanfoo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Will merge and roll a 1.2.1 release once CI passes. cc @leehart

@alimanfoo alimanfoo referenced this pull request May 31, 2019

Closed

1.2.1 release #267

3 of 3 tasks complete
@alimanfoo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Gah, still PEP8 issues, will fix.

@alimanfoo alimanfoo merged commit 0b7dadb into cggh:master May 31, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.