New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program::get() does not support GL_COMPUTE_WORK_GROUP_SIZE #354

Closed
paslange opened this Issue Aug 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@paslange

paslange commented Aug 28, 2017

The current signature of Program::get() returns a single integer, but glGetProgramiv() would return three values if GL_COMPUTE_WORK_GROUP_SIZE is passed as pname.

Additionally, the implementation of Program::get() assumes, that glGetProgramiv() writes a single value only, so that the stack will be corrupted if multiple integers are written. As far as I have seen, only GL_COMPUTE_WORK_GROUP_SIZE queries more than one integer.

@scheibel scheibel added the bug label Aug 29, 2017

@scheibel scheibel closed this in 275f159 Sep 28, 2017

@scheibel

This comment has been minimized.

Show comment
Hide comment
@scheibel

scheibel Sep 28, 2017

Member

Thanks for reporting.
You may now use program->get<3>(GL_COMPUTE_WORK_GROUP_SIZE) to query the work group sizes for compute programs.

Member

scheibel commented Sep 28, 2017

Thanks for reporting.
You may now use program->get<3>(GL_COMPUTE_WORK_GROUP_SIZE) to query the work group sizes for compute programs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment