New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 8 #8

Closed
pniederw opened this Issue Jun 1, 2014 · 11 comments

Comments

Projects
None yet
6 participants
@pniederw

pniederw commented Jun 1, 2014

cglib 3.1 doesn't seem to work under Java 8. In the best case, all that's required is to update to ASM 5 (see #7).

@raphw

This comment has been minimized.

Show comment
Hide comment
@raphw

raphw Jun 2, 2014

Member

The Spring framework simply repackages cglib with ASM 5. I tried to fix the official build but there seem quite some tests to be broken, even without the change. I fixed it in this pull request: #9

Member

raphw commented Jun 2, 2014

The Spring framework simply repackages cglib with ASM 5. I tried to fix the official build but there seem quite some tests to be broken, even without the change. I fixed it in this pull request: #9

@vetler

This comment has been minimized.

Show comment
Hide comment

vetler commented Aug 13, 2014

Please

@raphw

This comment has been minimized.

Show comment
Hide comment
@raphw

raphw Aug 13, 2014

Member

If you need instant release, check out bytebuddy.net - it fully supports Java 8.

Member

raphw commented Aug 13, 2014

If you need instant release, check out bytebuddy.net - it fully supports Java 8.

@sameb

This comment has been minimized.

Show comment
Hide comment
@sameb

sameb Aug 13, 2014

Contributor

@vetler, memes are cute but useless. Pull requests with patches are actually helpful.

Contributor

sameb commented Aug 13, 2014

@vetler, memes are cute but useless. Pull requests with patches are actually helpful.

@pniederw

This comment has been minimized.

Show comment
Hide comment
@pniederw

pniederw Aug 13, 2014

As far as I know, the pull requests for Java 8 support are already in, and what's missing is (only) a release. This is becoming a huge problem for downstream projects, as their Java 8 support hinges on CGLIB's Java 8 support.

As far as I know, the pull requests for Java 8 support are already in, and what's missing is (only) a release. This is becoming a huge problem for downstream projects, as their Java 8 support hinges on CGLIB's Java 8 support.

@sameb

This comment has been minimized.

Show comment
Hide comment
@sameb

sameb Aug 13, 2014

Contributor

i'm away on vacation for the next ~month. if someone wants to contribute
tests that the java8 changes actually worked in the meantime, that'd be
great. i don't have confidence that cglib currently actually supports
java8 language features the way you'd expect.

On Wed, Aug 13, 2014 at 12:07 PM, Peter Niederwieser <
notifications@github.com> wrote:

As far as I know, the pull requests for Java 8 support are already in, and
what's missing is (only) a release. This is becoming a huge problem for
downstream projects, as their Java 8 support hinges on CGLIB's Java 8
support.


Reply to this email directly or view it on GitHub
#8 (comment).

Contributor

sameb commented Aug 13, 2014

i'm away on vacation for the next ~month. if someone wants to contribute
tests that the java8 changes actually worked in the meantime, that'd be
great. i don't have confidence that cglib currently actually supports
java8 language features the way you'd expect.

On Wed, Aug 13, 2014 at 12:07 PM, Peter Niederwieser <
notifications@github.com> wrote:

As far as I know, the pull requests for Java 8 support are already in, and
what's missing is (only) a release. This is becoming a huge problem for
downstream projects, as their Java 8 support hinges on CGLIB's Java 8
support.


Reply to this email directly or view it on GitHub
#8 (comment).

@guw

This comment has been minimized.

Show comment
Hide comment
@guw

guw Sep 19, 2014

Contributor

I think there are two different issues: (a) support to run and work under Java 8 and (b) support for new Java 8 features. Should this be split into a separate issue?

Contributor

guw commented Sep 19, 2014

I think there are two different issues: (a) support to run and work under Java 8 and (b) support for new Java 8 features. Should this be split into a separate issue?

@raphw

This comment has been minimized.

Show comment
Hide comment
@raphw

raphw Sep 19, 2014

Member

Absolutely, this was already a matter of confusion in another issue.

Member

raphw commented Sep 19, 2014

Absolutely, this was already a matter of confusion in another issue.

@sameb

This comment has been minimized.

Show comment
Hide comment
@sameb

sameb Oct 27, 2014

Contributor

seems to be working fine w/ java8. could use a few java8 specific integration tests, but based on testing we've done with Guice+cglib, things seem to work OK. please open new bugs with details if there's specific java8 language features that aren't working with cglib.

Contributor

sameb commented Oct 27, 2014

seems to be working fine w/ java8. could use a few java8 specific integration tests, but based on testing we've done with Guice+cglib, things seem to work OK. please open new bugs with details if there's specific java8 language features that aren't working with cglib.

@sameb sameb closed this Oct 27, 2014

@cdeszaq

This comment has been minimized.

Show comment
Hide comment
@cdeszaq

cdeszaq Nov 24, 2014

@sameb, when you say seems to be working fine w/ java8, could you please elaborate a bit? Which version is it that seems to be working fine?

As mentioned earlier, "running and working under Java 8" is different from "supporting new Java 8 features". To me, taking a working Java 7 sample and running it correctly under Java 8 is sufficient for "running and working under Java 8".

cdeszaq commented Nov 24, 2014

@sameb, when you say seems to be working fine w/ java8, could you please elaborate a bit? Which version is it that seems to be working fine?

As mentioned earlier, "running and working under Java 8" is different from "supporting new Java 8 features". To me, taking a working Java 7 sample and running it correctly under Java 8 is sufficient for "running and working under Java 8".

@sameb

This comment has been minimized.

Show comment
Hide comment
@sameb

sameb Nov 24, 2014

Contributor

Please file bugs for the Java 8 features that aren't working, along with tests that show they aren't working.

Contributor

sameb commented Nov 24, 2014

Please file bugs for the Java 8 features that aren't working, along with tests that show they aren't working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment