Generate OSGi manifest headers

[SourcePond]

Packaging phase for cglib-nodep and cglib uses now the
maven-bundle-plugin instead of the regular JAR plugin. This makes the
cglib a regular OSGi bundle. For non-OSGi environments, this change has
no effect.

[vlsi]

Please use 4 spaces, not tabs for indent

[vlsi]

Can you please add a test that verifies that OSGi bundle does work as an OSGi bundle?

[sameb]

please change to 4 spaces indent, not 8.

[vlsi]

@SourcePond , there are still lots of tabs.

Can you add a test case that examines basic cglib functionality to make sure Enhancer/etc works as expected?
I'm not sure if reuse of existing test classes is possible though.

[vlsi]

Re "osgi garbage output" in Travis, can you please try something like this one https://github.com/pgjdbc/pgjdbc/pull/507/files#diff-48464aa7428b12eaf5b57200b1afa8aeR16?

[SourcePond]

Hmm, I'm not sure how to fix the build. The OSGi integration tests need the cglib/cglib-nodep artifacts to be available. I tried to change "mvn test" to "mvn install" in .travis.yml but that didn't work. Do you have an idea what to do?

Another question: do you have a rule file to import into Eclipse so that I can format my code as it should be?

[vlsi]

Another question: do you have a rule file to import into Eclipse so that I can format my code as it should be?

I'm not aware of those.

[vlsi]

I tried to change "mvn test" to "mvn install" in .travis.yml but that didn't work. Do you have an idea what to do?

I think your change of mvn test to mvn install is right. At least the build did pass for JDK8: https://travis-ci.org/cglib/cglib/builds/140841857

[sameb]

it looks like its just the doclint in javadoc that is breaking on pre-java8. if one of the maven changes tried to somehow add javadoc, there's weirdness with working both pre and post java8.

see how guice handles it in its pom: https://github.com/google/guice/blob/master/pom.xml#L438

... it looks like something is trying to enable doclint for all jvms, not just jdk8+, and that's what's causing the maven failures

[cschneider]

I would be quite interested in this change. Can I help in any way?

[SourcePond]

The problem is to get the build work with JDK6. The maven-bundle-plugin needs at least JDK7. My solution would be to run the JDK6 build with JDK7, but, let the tests run with JDK6. I'll investigate this somewhen this week.