New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-85440 #269

Closed
wants to merge 232 commits into
base: master
from

Conversation

Projects
None yet
@brianchandotcom

brianchandotcom commented Oct 3, 2018

No description provided.

adolfopa and others added some commits Jul 26, 2018

LPS-85893 Introduce new type to accuratelly represent version changes
Currently, a boolean is used as a parameter to methods that may
potentially bump a file version number. This is not correct, as there
are 3 possible states: minor version, major version or none.

Previously, there was logic in place to guess what the user
wanted (removed in LPS-82101). This new type will let callers specify
explicitly what they really want.
LPS-85870 PortletRequestDispatcher.forward(RenderRequest,RenderRespon…
…se) does not forward to resources such as plain HTML document files
LPS-85640 journal-test-util: Move classes from portal-search-test to …
…journal-test-util

https://issues.liferay.com/browse/LPS-85640

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
LPS-85640 journal-test: Use classes from journal-test-util
https://issues.liferay.com/browse/LPS-85640

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
LPS-85640 portal-search-test: Move classes from portal-search-test to…
… journal-test-util

https://issues.liferay.com/browse/LPS-85640

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
LPS-85640 portal-search-test: Use classes from journal-test-util
https://issues.liferay.com/browse/LPS-85640

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
@liferay-continuous-integration

This comment has been minimized.

Collaborator

liferay-continuous-integration commented Oct 3, 2018

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@brianchandotcom

This comment has been minimized.

brianchandotcom commented Oct 3, 2018

@cgoncas

This comment has been minimized.

Owner

cgoncas commented Oct 3, 2018

Just started reviewing :)

:octocat: Sent from GH.

@cgoncas

This comment has been minimized.

Owner

cgoncas commented Oct 3, 2018

Pull request submitted to brianchandotcom#63713. See changes here.

:octocat: Sent from GH.

@cgoncas

This comment has been minimized.

Owner

cgoncas commented Oct 3, 2018

Pull request submitted to brianchandotcom#63714. See changes here.

:octocat: Sent from GH.

@cgoncas

This comment has been minimized.

Owner

cgoncas commented Oct 3, 2018

Pull request submitted to brianchandotcom#63718. See changes here.

:octocat: Sent from GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment