Fixed a bug with replace-vars and multiple vars in the same node#65
Closed
aviflax wants to merge 2 commits into
Closed
Fixed a bug with replace-vars and multiple vars in the same node#65aviflax wants to merge 2 commits into
aviflax wants to merge 2 commits into
Conversation
The regex was a little too loose, so it was capturing everything from the beginning of the first var and the end of the last as if it was one var.
ebaxt
added a commit
to ebaxt/enlive
that referenced
this pull request
May 10, 2013
Author
|
@cgrand OK, I added a fix for single-char vars, along with a new test. |
Owner
|
@aviflax sorry i missed the notification for your latest patch. |
Author
|
So… you don’t want to merge this? |
Owner
|
I pushed a similar commit before noticing your latest patch. |
Author
|
Ah, I see. OK then, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex was a little too loose, so it was capturing everything from the beginning of the first var and the end of the last as if it was one var.