From a909451a51a907ee90969213a56e4e6ecc0b03de Mon Sep 17 00:00:00 2001 From: aarzilli Date: Sun, 13 Sep 2015 12:49:13 +0200 Subject: [PATCH] Add missing alignment padding to SetupRequest struct Fields AuthorizationProtocolName and AuthorizationProtocolData of SetupRequest should be padded: http://www.x.org/releases/current/doc/xproto/x11protocol.html#Encoding::Connection_Setup The problem was discovered by github user pphaneuf while trying to use xgb to write his own implementation of the connection handshake. Neither xgb nor xcb actually use code generated for SetupRequest for the handshake, which is why this bug went unnoticed. https://github.com/BurntSushi/xgb/issues/24 Alessandro Arzilli. Reviewed-by: Christian Linhart --- src/xproto.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xproto.xml b/src/xproto.xml index 437dc30..dea48df 100644 --- a/src/xproto.xml +++ b/src/xproto.xml @@ -198,9 +198,11 @@ authorization from the authors. authorization_protocol_name_len + authorization_protocol_data_len +