Allow multiple formats of association links #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed formats are allowed for now: - /questions/123/question-title - /q/123/234 - /a/321/234
chabanovsky
reviewed
Mar 18, 2017
| function questionId(uri) { | ||
| var id = /\/(\d+)\//.exec(uri) | ||
| return id == null ? -1 : id[1]; | ||
| function questionId(uri, site) { |
There was a problem hiding this comment.
It looks like this function is called with uri that contains "stackoverflow.com/*". At the same time, the "site" contains a link to the current site (which means "ru.stackoverflow.com" for example). It seems that it should not work. Could you please check it?
There was a problem hiding this comment.
site is a questionId argument.
questionId function has to be used 2 times in this script.
- In
checkPage(document.baseURI)
withquestionId('ru.stackoverflow.com/...', 'ru.stackoverflow.com')call - In
getSEQuestionId({comment, linkToSE})
withquestionId('stackoverflow.com/...', 'stackoverflow')
Where is nothing wrong.
There was a problem hiding this comment.
But, site argument value can be parsed from uri content and looks like redundant.
I was adding it just because we already parse it in getSEQuestionId
|
Close PR because it is fairly outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed formats are allowed for now: