New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring based on a better understanding of ring and compojure: #16

Merged
merged 1 commit into from Nov 4, 2017

Conversation

Projects
None yet
1 participant
@chadhs
Copy link
Owner

chadhs commented Nov 4, 2017

  • returning html output and letting compojure build the ring response
    to allow for better compatability with ring-defaults middleware
  • using ring.util.response for redirects rather than building a map
    manually
  • changed route param refs to keywords to work with ring-defaults
    keywordize params
  • updated middleware call to wrap-defaults site-defaults
refactoring based on a better understanding of ring and compojure:
- returning html output and letting compojure build the ring response
  to allow for better compatability with ring-defaults middleware
- using ring.util.response for redirects rather than building a map
  manually
- changed route param refs to keywords to work with ring-defaults
  keywordize params
- updated middleware call to wrap-defaults site-defaults

@chadhs chadhs merged commit df90d71 into master Nov 4, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment