From baf4e30600994a22790ec1efb56fd0f9d66e3ff8 Mon Sep 17 00:00:00 2001
From: Michael Schmidt <mitchi5000.ms@googlemail.com>
Date: Sat, 8 Apr 2023 22:32:28 +0200
Subject: [PATCH] Consider output error for connectability

---
 src/common/types/function.ts              | 12 +++++++++++
 src/renderer/contexts/GlobalNodeState.tsx | 26 +++++++++++++++++++++--
 2 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/src/common/types/function.ts b/src/common/types/function.ts
index e97611086f..a0abd0d402 100644
--- a/src/common/types/function.ts
+++ b/src/common/types/function.ts
@@ -606,4 +606,16 @@ export class FunctionInstance {
         // we say that types A is assignable to type B if they are not disjoint
         return !isDisjointWith(iType, this.definition.convertInput(inputId, type));
     }
+
+    /**
+     * Returns a new function instance with the given input assigned to the given type.
+     */
+    withInput(inputId: InputId, type: NonNeverType): FunctionInstance {
+        return FunctionInstance.fromPartialInputs(this.definition, (id) => {
+            if (id === inputId) {
+                return type;
+            }
+            return this.inputs.get(id);
+        });
+    }
 }
diff --git a/src/renderer/contexts/GlobalNodeState.tsx b/src/renderer/contexts/GlobalNodeState.tsx
index f55ea3559d..6b7f783de1 100644
--- a/src/renderer/contexts/GlobalNodeState.tsx
+++ b/src/renderer/contexts/GlobalNodeState.tsx
@@ -862,7 +862,7 @@ export const GlobalProvider = memo(
 
                 const outputType = sourceFn.outputs.get(sourceHandleId);
                 if (outputType !== undefined && !targetFn.canAssign(targetHandleId, outputType)) {
-                    const schema = schemata.get(targetNode.data.schemaId);
+                    const { schema } = targetFn.definition;
                     const input = schema.inputs.find((i) => i.id === targetHandleId)!;
                     const inputType = withoutNull(
                         targetFn.definition.inputDefaults.get(targetHandleId)!
@@ -885,6 +885,28 @@ export const GlobalProvider = memo(
                     );
                 }
 
+                if (
+                    outputType !== undefined &&
+                    targetFn.inputErrors.length === 0 &&
+                    targetFn.outputErrors.length === 0
+                ) {
+                    const assignedFn = targetFn.withInput(targetHandleId, outputType);
+                    if (assignedFn.outputErrors.length > 0) {
+                        // the assigned caused output error
+                        const errorId = assignedFn.outputErrors[0].outputId;
+
+                        const { schema } = targetFn.definition;
+                        const output = schema.outputs.find((o) => o.id === errorId)!;
+
+                        if (output.neverReason) {
+                            return invalid(
+                                `Connection would cause the following error: ${output.neverReason}`
+                            );
+                        }
+                        return invalid(`Connection would cause an output error.`);
+                    }
+                }
+
                 const checkTargetChildren = (parentNode: Node<NodeData>): boolean => {
                     const targetChildren = getOutgoers(parentNode, getNodes(), getEdges());
                     if (!targetChildren.length) {
@@ -909,7 +931,7 @@ export const GlobalProvider = memo(
 
                 return VALID;
             },
-            [typeState.functions, getNode, getNodes, getEdges, schemata]
+            [typeState.functions, getNode, getNodes, getEdges]
         );
 
         const [inputDataChanges, addInputDataChanges] = useChangeCounter();