Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch logicalparadox refs to chaijs #79

Closed
mLuby opened this issue Aug 30, 2017 · 4 comments

Comments

@mLuby
Copy link
Contributor

commented Aug 30, 2017

At least three places reference the old repo: logicalparadox/chai-spies which is a dead link.

  1. README.md

  2. npmjs.com/chai-spies

screen shot 2017-08-30 at 12 55 34 pm
  1. chaijs.com/plugins/chai-spies
screen shot 2017-08-30 at 12 55 46 pm

I'm happy to open a PR for 1 but I don't know where to fix 2 and 3.

@stalniy

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

@keithamus any thoughts on this?

Update: I guess we need just release a new version to npm and it will update its page after a while but don't know about chais website

@stalniy

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

meanwhile, @mLuby , could you please make a PR to fix README?

@keithamus also I think it's time to release as chai-spies has not been released for 2 years :)

@keithamus

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

yeah happy to cut a release of chai-spies. Let's get it in a good shape for a major version and release as 1.0.0 😄

We can close this - the package.json reflects the up to date url, and when we cut a release the chai site is automatically updated. So there's no action on our part.

@mLuby

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2017

@stalniy here's the tiny PR #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.