Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .with when multiple identical arguments #56

Merged
merged 2 commits into from Aug 17, 2016

Conversation

@meeber
Copy link
Contributor

commented Jun 22, 2016

  • Fixes #45
  • Fixes expected value in failed assertion message
  • Refactors code that was duplicated between both logic branches of .always
@meeber

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2016

@keithamus Whoops I never pinged you and I totally forgot about this. Ping!

@keithamus

This comment has been minimized.

Copy link
Member

commented Aug 16, 2016

This LGTM 👍 good job @meeber

@meeber

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2016

@keithamus Hmm, do I need to cheat and self LGTM here?

@keithamus keithamus merged commit b522148 into chaijs:master Aug 17, 2016
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keithamus

This comment has been minimized.

Copy link
Member

commented Aug 17, 2016

Looks so 😆

@meeber meeber referenced this pull request May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.