Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #92

Merged
merged 2 commits into from Jan 10, 2018

Conversation

@stalniy
Copy link
Contributor

commented Jan 10, 2018

  • documentation
  • package.json
@keithamus

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@stalniy as part of this I think we should also drop Node < 4 from the package.json, and no longer support it. Thoughts?

@stalniy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2018

@keithamus this was done in #91

@keithamus

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

Yup 😆 just saw that and merged.

@keithamus

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

If you rebase this against master, the tests will pass and I will merge 👍

Lena Stotska added 2 commits Jan 10, 2018
deprecates chai.spy.returns
@stalniy stalniy force-pushed the stalniy:chore/release branch from 7677de9 to 35afb53 Jan 10, 2018
@stalniy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2018

Done! lets merge this :)

@meeber
meeber approved these changes Jan 10, 2018
Copy link
Contributor

left a comment

LGTM

@stalniy stalniy merged commit 9a2d248 into chaijs:master Jan 10, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
validate-commit-msg all commit messages are valid
Details
@stalniy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2018

@keithamus what do we need to do next to publish 1.0.0 on npm?

@keithamus

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@stalniy could you please add some release notes to https://github.com/chaijs/chai-spies/releases/edit/untagged-c4a7ec2f780e17401aef and then hit Publish - CI will take care of the rest.

@stalniy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2018

Cool! @keithamus what do you think about merging #93 in 1.0.0 as well?

@keithamus

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

Ideally the format should be:

General release notes go here

# Breaking Changes
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)

# Bug Fixes
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)

# Docs
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)
@stalniy stalniy deleted the stalniy:chore/release branch Jan 11, 2018
@stalniy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2018

Sorry @keithamus , missed your last message. I will change the format. Do you use some tool to generate release notes?

@stalniy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2018

Also npm i chai-spies@1.0.0 fails and npm i chai-spies@latest installs 0.7.1 version. Are there some issues with CI pipeline or you decided to postpone release to fix release notes format?

@stalniy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2018

@keithamus updated release notes according to recommended format, also added Bug Fixes section. Could you please review draft, publish if everything is ok and make sure CI build updated version on npm?

@keithamus

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

I've gone ahead and manually published chai-spies@1.0.0 - it looks like it didnt publish on CI, I'll get around to fixing that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.