New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugs in the deepEqual algorithm #793

Closed
ghost opened this Issue Sep 10, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Sep 10, 2016

Hey! There are various bugs in your deepEqual algortihm, and a lot of features aren't support. E.g. ES2016 lacks support. I mention some of it here in my own algorithm:
https://github.com/Kflash/boogy#boogy-vs-other-deepequal-algorithms

If you try to compare symbols you get this thrown at you: TypeError: Cannot convert a Symbol value to a string

@meeber

This comment has been minimized.

Show comment
Hide comment
@meeber

meeber Sep 10, 2016

Contributor

@KFlash Chai's deep-equal is undergoing a tremendous refactor over here. It's the last major feature we have planned for the upcoming release of Chai 4.0. @keithamus can speak to it better than I if the planned refactor covers the issues you've identified in the current Chai.

Contributor

meeber commented Sep 10, 2016

@KFlash Chai's deep-equal is undergoing a tremendous refactor over here. It's the last major feature we have planned for the upcoming release of Chai 4.0. @keithamus can speak to it better than I if the planned refactor covers the issues you've identified in the current Chai.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 10, 2016

@meeber I looked at it. Seems to cover some of it, but not sure of it's cover the circular references issues etc I also discovered earlier.

ghost commented Sep 10, 2016

@meeber I looked at it. Seems to cover some of it, but not sure of it's cover the circular references issues etc I also discovered earlier.

@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Sep 11, 2016

Member

Yes, the new deep-equal should support all types. Hopefully it will make it into 4.0 and will solve this issue, but let's keep it open for now.

Member

keithamus commented Sep 11, 2016

Yes, the new deep-equal should support all types. Hopefully it will make it into 4.0 and will solve this issue, but let's keep it open for now.

@keithamus keithamus referenced this issue Sep 30, 2016

Closed

Chai Roadmap #457

4 of 10 tasks complete
@meeber

This comment has been minimized.

Show comment
Hide comment
@meeber

meeber Nov 25, 2016

Contributor

This was addressed in the latest deep-eql release.

Contributor

meeber commented Nov 25, 2016

This was addressed in the latest deep-eql release.

@meeber meeber closed this Nov 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment