Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Due to commit 4d45c5d, chai.js now requires json-loader, which is not included in Webpack 1.
Webpack 2 has a built-in json loader, so it is not affected.
Workarounds: user can manually add json-loader to his webpack 1 configuration, or use webpack 2.
The text was updated successfully, but these errors were encountered:
That's a breaking change. I had to add:
+extensions: ['.js', '.json'],
Sorry, something went wrong.
Fix build broken by chaijs/chai#985
Hey @AviVahl, thanks for your issue
I believe that this should be fixed once #986 gets merged and published
Let me know if I'm missing something
Thank you for addressing this. 👍 I'll verify (and close the ticket) once 4.0.2 is out.
In chai.js the line exports.version = require('../package').version; is DRY, but it is brittle with regard to webpack and also wallabyjs.
exports.version = require('../package').version;
In order to get things working with wallaby any override of webpackConfig.resolve.extensions needs to include .json. This is an extension of the modification suggested by @oliviertassinari.
Closed via #986. We'll get a release out soon.
No branches or pull requests