Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json - deprecation warning on exports field #1400

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: package.json - deprecation warning on exports field #1400

merged 1 commit into from
Jan 25, 2022

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jun 7, 2021

Issue resolved #1387
Issue resolved #1406

@stevenjoezhang stevenjoezhang requested a review from a team as a code owner June 7, 2021 18:05
@Alhadis
Copy link
Contributor

Alhadis commented Jun 23, 2021

@keithamus Any chance we could squeeze this in as patch release (say, v4.3.5)? I understand Chai is slated for a major version bump (meaning breaking and/or non-trivial changes), so anybody unable to upgrade for whatever reason will be stuck seeing this deprecation warning.

@d-fischer
Copy link

Please fix this. As of node 17, this is completely broken.

[ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './register-expect' is not defined by "exports" in /home/daniel/Projekte/cross-fetch/node_modules/chai/package.json

@keithamus keithamus enabled auto-merge (squash) January 25, 2022 14:32
@keithamus keithamus merged commit 53315df into chaijs:main Jan 25, 2022
keithamus added a commit that referenced this pull request Feb 7, 2023
* Fixed a regression that caused SyntaxErrors on IE 11

The changes made in #1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai.

* chai@4.3.2

* export chai.Assertion (#1378)

* chai@4.3.3

* fix: support inspecting bigints (#1321) (#1383)

* 4.3.4

* feat: use chaijs/loupe for inspection (#1401) (#1407)

Fix #1228

* fix: package.json - deprecation warning on exports field (#1400)

* fix package.json exports

* build(deps-dev): bump codecov from 3.1.0 to 3.7.1 (#1446)

Bumps [codecov](https://github.com/codecov/codecov-node) from 3.1.0 to 3.7.1.
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-node@v3.1.0...v3.7.1)

---
updated-dependencies:
- dependency-name: codecov
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build chaijs

* 4.3.5

* fix: use loupe@^2.3.1

* build chaijs

* 4.3.6

* fix: deep-eql bump package to support symbols comparison (#1483)

* 4.3.7

* build

* chore: 4.x.x: Fix link to commit logs on GitHub (#1487)

* 4.x.x: Fix link to commit logs on GitHub

As there is no `master` branch, the link returned a 404.

* Update History.md

Co-authored-by: Andre Meyering <info@andremeyering.de>

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>

* build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (#1488)

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test: fix typo in test.js (#1459)

* docs: specify return type of objDisplay (#1490)

previously it was incorrectly labeled as `objDisplay(obj: object): void` in `@types/chai`.

* feat: rework into ES modules

This moves all of the sources to be ES modules rather than CommonJS.

In order to produce the entrypoints, we use esbuild as a bundler (and as
a transpiler in a way).

Due to the fact that some dependencies are written in CommonJS, we
actually use esbuild to create _two_ bundles: a CommonJS bundle, and an
ES module bundle.

Otherwise, someone importing the raw source would inevitably end up
trying to import a CommonJS module somewhere down the tree, which would
not work in browsers natively.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Lee Newson <lnewso@hotmail.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: rbruckheimer <rob@cosaic.io>
Co-authored-by: Mike Frysinger <vapier@gmail.com>
Co-authored-by: Pascal Corpet <pcorpet@users.noreply.github.com>
Co-authored-by: Mimi <stevenjoezhang@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scott Newcomer <snewcomer@users.noreply.github.com>
Co-authored-by: Andre Meyering <info@andremeyering.de>
Co-authored-by: Mavaddat Javid <5055400+mavaddat@users.noreply.github.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: James Garbutt <james.garbutt@crispthinking.com>
renovate bot added a commit to runtime-env/import-meta-env that referenced this pull request Jul 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai))
| [`4.4.1` ->
`5.1.1`](https://renovatebot.com/diffs/npm/chai/4.4.1/5.1.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>chaijs/chai (chai)</summary>

### [`v5.1.1`](https://togithub.com/chaijs/chai/releases/tag/v5.1.1)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.1.0...v5.1.1)

#### What's Changed

- Set up ESLint for JSDoc comments by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1605
- build(deps-dev): bump ip from 1.1.8 to 1.1.9 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[chaijs/chai#1608
- Correct Mocha import instructions by
[@&#8203;MattiSG](https://togithub.com/MattiSG) in
[chaijs/chai#1611
- fix: support some virtual contexts in `toThrow` by
[@&#8203;43081j](https://togithub.com/43081j) in
[chaijs/chai#1609

#### New Contributors

- [@&#8203;MattiSG](https://togithub.com/MattiSG) made their first
contribution in
[chaijs/chai#1611

**Full Changelog**:
chaijs/chai@v5.1.0...v5.1.1

### [`v5.1.0`](https://togithub.com/chaijs/chai/releases/tag/v5.1.0)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.0.3...v5.1.0)

#### What's Changed

- Remove useless guards and add parentheses to constuctors by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1593
- Cleanup jsdoc comments by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1596
- Convert comments in "legal comments" format to jsdoc or normal
comments by [@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1598
- Implement `iterable` assertion by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1592
- Assert interface fix by
[@&#8203;developer-bandi](https://togithub.com/developer-bandi) in
[chaijs/chai#1601
- Set support in same members by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1583
- Fix publish script by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1602

#### New Contributors

- [@&#8203;developer-bandi](https://togithub.com/developer-bandi) made
their first contribution in
[chaijs/chai#1601

**Full Changelog**:
chaijs/chai@v5.0.3...v5.1.0

### [`v5.0.3`](https://togithub.com/chaijs/chai/releases/tag/v5.0.3)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.0.2...v5.0.3)

Fix bad v5.0.2 publish.

**Full Changelog**:
chaijs/chai@v5.0.2...v5.0.3

### [`v5.0.2`](https://togithub.com/chaijs/chai/releases/tag/v5.0.2)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.0.0...v5.0.2)

#### What's Changed

- build(deps): bump nanoid and mocha by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[chaijs/chai#1558
- remove `bump-cli` by [@&#8203;koddsson](https://togithub.com/koddsson)
in
[chaijs/chai#1559
- Update developer dependencies by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1560
- fix: removes `??` for node compat (5.x) by
[@&#8203;43081j](https://togithub.com/43081j) in
[chaijs/chai#1576
- Update `loupe` to latest version by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1579
- Re-enable some webkit tests by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1580
- Remove a bunch of if statements in test/should.js by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1581
- Remove a bunch of unused files by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1582
- Fix 1564 by [@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1566

**Full Changelog**:
chaijs/chai@v5.0.1...v5.0.2

### [`v5.0.0`](https://togithub.com/chaijs/chai/releases/tag/v5.0.0)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v4.4.1...v5.0.0)

#### BREAKING CHANGES

- Chai now only supports EcmaScript Modules (ESM). This means your tests
will need to either have `import {...} from 'chai'` or `import('chai')`.
`require('chai')` will cause failures in nodejs. If you're using ESM and
seeing failures, it may be due to a bundler or transpiler which is
incorrectly converting import statements into require calls.
-   Dropped support for Internet Explorer.
-   Dropped support for NodeJS < 18.
- Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome
100, Edge 100. Support for browsers prior to these versions is "best
effort" (bug reports on older browsers will be assessed individually and
may be marked as wontfix).

#### What's Changed

- feat: use chaijs/loupe for inspection by
[@&#8203;pcorpet](https://togithub.com/pcorpet) in
[chaijs/chai#1401
- docs: fix URL in README by [@&#8203;Izzur](https://togithub.com/Izzur)
in
[chaijs/chai#1413
- Remove `get-func-name` dependency by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1416
- Convert Makefile script to npm scripts by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1424
- Clean up README badges by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1422
- fix: package.json - deprecation warning on exports field by
[@&#8203;stevenjoezhang](https://togithub.com/stevenjoezhang) in
[chaijs/chai#1400
- fix: deep-eql bump package to support symbols by
[@&#8203;snewcomer](https://togithub.com/snewcomer) in
[chaijs/chai#1458
- ES module conversion PoC by
[@&#8203;43081j](https://togithub.com/43081j) in
[chaijs/chai#1498
- chore: drop commonjs support by
[@&#8203;43081j](https://togithub.com/43081j) in
[chaijs/chai#1503
- Update pathval by [@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1527
- Update check-error by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1528
- update `deep-eql` to latest version by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1542
- Inline `type-detect` as a simple function by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1544
- Update loupe by [@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1545
- Typo 'Test an object' not 'Test and object' by
[@&#8203;mavaddat](https://togithub.com/mavaddat) in
[chaijs/chai#1460
- Update `assertion-error` to it's latest major version! by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1543
- Replacing Karma with Web Test Runner by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[chaijs/chai#1546

#### New Contributors

- [@&#8203;Izzur](https://togithub.com/Izzur) made their first
contribution in
[chaijs/chai#1413
- [@&#8203;stevenjoezhang](https://togithub.com/stevenjoezhang) made
their first contribution in
[chaijs/chai#1400
- [@&#8203;43081j](https://togithub.com/43081j) made their first
contribution in
[chaijs/chai#1498

**Full Changelog**:
chaijs/chai@4.3.1...v5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/runtime-env/import-meta-env).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants