Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json - deprecation warning on exports field #1400

Merged
merged 1 commit into from Jan 25, 2022
Merged

fix: package.json - deprecation warning on exports field #1400

merged 1 commit into from Jan 25, 2022

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jun 7, 2021

Issue resolved #1387
Issue resolved #1406

@stevenjoezhang stevenjoezhang requested a review from a team as a code owner Jun 7, 2021
@Alhadis
Copy link
Contributor

Alhadis commented Jun 23, 2021

@keithamus Any chance we could squeeze this in as patch release (say, v4.3.5)? I understand Chai is slated for a major version bump (meaning breaking and/or non-trivial changes), so anybody unable to upgrade for whatever reason will be stuck seeing this deprecation warning.

@d-fischer
Copy link

d-fischer commented Jan 23, 2022

Please fix this. As of node 17, this is completely broken.

[ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './register-expect' is not defined by "exports" in /home/daniel/Projekte/cross-fetch/node_modules/chai/package.json

@keithamus keithamus enabled auto-merge (squash) Jan 25, 2022
@keithamus keithamus disabled auto-merge Jan 25, 2022
@keithamus keithamus merged commit 53315df into chaijs:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants