Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline type-detect as a simple function #1544

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Inline type-detect as a simple function #1544

merged 4 commits into from
Oct 20, 2023

Conversation

koddsson
Copy link
Member

I think the type-detect function can be deprecated as all there is much more spec conformance than was when type-detect was created.

@koddsson koddsson marked this pull request as ready for review October 20, 2023 07:42
@koddsson koddsson requested a review from a team as a code owner October 20, 2023 07:42
keithamus
keithamus previously approved these changes Oct 20, 2023
View reviewed changes
lib/chai/utils/type-detect.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@43081j
Copy link
Contributor

43081j commented Oct 20, 2023

you're probably right but it does mean we'd be missing the special results like global right?

i.e. it looks like the old one type(globalThis) === 'global'

keithamus
keithamus approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

@koddsson koddsson merged commit 9e276dc into chaijs:5.x.x Oct 20, 2023
3 checks passed
@koddsson koddsson deleted the remove-type-detect branch October 20, 2023 12:42
@koddsson koddsson mentioned this pull request Oct 25, 2023
Merged
@lholmquist lholmquist mentioned this pull request May 30, 2024
Closed
@taeb3 taeb3 mentioned this pull request May 31, 2024
Open
@anand-py anand-py mentioned this pull request Jun 2, 2024
Open
@WontonSam WontonSam mentioned this pull request Jun 8, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Merged
renovate bot referenced this pull request in runtime-env/import-meta-env Jul 7, 2024
@renovate
chore(deps): update dependency chai to v5 (#1307)
5c86043 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai))
| [`4.4.1` ->
`5.1.1`](https://renovatebot.com/diffs/npm/chai/4.4.1/5.1.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>chaijs/chai (chai)</summary>

### [`v5.1.1`](https://togithub.com/chaijs/chai/releases/tag/v5.1.1)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.1.0...v5.1.1)

#### What's Changed

- Set up ESLint for JSDoc comments by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1605](https://togithub.com/chaijs/chai/pull/1605)
- build(deps-dev): bump ip from 1.1.8 to 1.1.9 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/chaijs/chai/pull/1608](https://togithub.com/chaijs/chai/pull/1608)
- Correct Mocha import instructions by
[@&#8203;MattiSG](https://togithub.com/MattiSG) in
[https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611)
- fix: support some virtual contexts in `toThrow` by
[@&#8203;43081j](https://togithub.com/43081j) in
[https://github.com/chaijs/chai/pull/1609](https://togithub.com/chaijs/chai/pull/1609)

#### New Contributors

- [@&#8203;MattiSG](https://togithub.com/MattiSG) made their first
contribution in
[https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611)

**Full Changelog**:
chaijs/chai@v5.1.0...v5.1.1

### [`v5.1.0`](https://togithub.com/chaijs/chai/releases/tag/v5.1.0)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.0.3...v5.1.0)

#### What's Changed

- Remove useless guards and add parentheses to constuctors by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1593](https://togithub.com/chaijs/chai/pull/1593)
- Cleanup jsdoc comments by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1596](https://togithub.com/chaijs/chai/pull/1596)
- Convert comments in "legal comments" format to jsdoc or normal
comments by [@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1598](https://togithub.com/chaijs/chai/pull/1598)
- Implement `iterable` assertion by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1592](https://togithub.com/chaijs/chai/pull/1592)
- Assert interface fix by
[@&#8203;developer-bandi](https://togithub.com/developer-bandi) in
[https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601)
- Set support in same members by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1583](https://togithub.com/chaijs/chai/pull/1583)
- Fix publish script by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1602](https://togithub.com/chaijs/chai/pull/1602)

#### New Contributors

- [@&#8203;developer-bandi](https://togithub.com/developer-bandi) made
their first contribution in
[https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601)

**Full Changelog**:
chaijs/chai@v5.0.3...v5.1.0

### [`v5.0.3`](https://togithub.com/chaijs/chai/releases/tag/v5.0.3)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.0.2...v5.0.3)

Fix bad v5.0.2 publish.

**Full Changelog**:
chaijs/chai@v5.0.2...v5.0.3

### [`v5.0.2`](https://togithub.com/chaijs/chai/releases/tag/v5.0.2)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v5.0.0...v5.0.2)

#### What's Changed

- build(deps): bump nanoid and mocha by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/chaijs/chai/pull/1558](https://togithub.com/chaijs/chai/pull/1558)
- remove `bump-cli` by [@&#8203;koddsson](https://togithub.com/koddsson)
in
[https://github.com/chaijs/chai/pull/1559](https://togithub.com/chaijs/chai/pull/1559)
- Update developer dependencies by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1560](https://togithub.com/chaijs/chai/pull/1560)
- fix: removes `??` for node compat (5.x) by
[@&#8203;43081j](https://togithub.com/43081j) in
[https://github.com/chaijs/chai/pull/1576](https://togithub.com/chaijs/chai/pull/1576)
- Update `loupe` to latest version by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1579](https://togithub.com/chaijs/chai/pull/1579)
- Re-enable some webkit tests by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1580](https://togithub.com/chaijs/chai/pull/1580)
- Remove a bunch of if statements in test/should.js by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1581](https://togithub.com/chaijs/chai/pull/1581)
- Remove a bunch of unused files by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1582](https://togithub.com/chaijs/chai/pull/1582)
- Fix 1564 by [@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1566](https://togithub.com/chaijs/chai/pull/1566)

**Full Changelog**:
chaijs/chai@v5.0.1...v5.0.2

### [`v5.0.0`](https://togithub.com/chaijs/chai/releases/tag/v5.0.0)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v4.4.1...v5.0.0)

#### BREAKING CHANGES

- Chai now only supports EcmaScript Modules (ESM). This means your tests
will need to either have `import {...} from 'chai'` or `import('chai')`.
`require('chai')` will cause failures in nodejs. If you're using ESM and
seeing failures, it may be due to a bundler or transpiler which is
incorrectly converting import statements into require calls.
-   Dropped support for Internet Explorer.
-   Dropped support for NodeJS < 18.
- Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome
100, Edge 100. Support for browsers prior to these versions is "best
effort" (bug reports on older browsers will be assessed individually and
may be marked as wontfix).

#### What's Changed

- feat: use chaijs/loupe for inspection by
[@&#8203;pcorpet](https://togithub.com/pcorpet) in
[https://github.com/chaijs/chai/pull/1401](https://togithub.com/chaijs/chai/pull/1401)
- docs: fix URL in README by [@&#8203;Izzur](https://togithub.com/Izzur)
in
[https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413)
- Remove `get-func-name` dependency by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1416](https://togithub.com/chaijs/chai/pull/1416)
- Convert Makefile script to npm scripts by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1424](https://togithub.com/chaijs/chai/pull/1424)
- Clean up README badges by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1422](https://togithub.com/chaijs/chai/pull/1422)
- fix: package.json - deprecation warning on exports field by
[@&#8203;stevenjoezhang](https://togithub.com/stevenjoezhang) in
[https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400)
- fix: deep-eql bump package to support symbols by
[@&#8203;snewcomer](https://togithub.com/snewcomer) in
[https://github.com/chaijs/chai/pull/1458](https://togithub.com/chaijs/chai/pull/1458)
- ES module conversion PoC by
[@&#8203;43081j](https://togithub.com/43081j) in
[https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498)
- chore: drop commonjs support by
[@&#8203;43081j](https://togithub.com/43081j) in
[https://github.com/chaijs/chai/pull/1503](https://togithub.com/chaijs/chai/pull/1503)
- Update pathval by [@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1527](https://togithub.com/chaijs/chai/pull/1527)
- Update check-error by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1528](https://togithub.com/chaijs/chai/pull/1528)
- update `deep-eql` to latest version by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1542](https://togithub.com/chaijs/chai/pull/1542)
- Inline `type-detect` as a simple function by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1544](https://togithub.com/chaijs/chai/pull/1544)
- Update loupe by [@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1545](https://togithub.com/chaijs/chai/pull/1545)
- Typo 'Test an object' not 'Test and object' by
[@&#8203;mavaddat](https://togithub.com/mavaddat) in
[https://github.com/chaijs/chai/pull/1460](https://togithub.com/chaijs/chai/pull/1460)
- Update `assertion-error` to it's latest major version! by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1543](https://togithub.com/chaijs/chai/pull/1543)
- Replacing Karma with Web Test Runner by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/chaijs/chai/pull/1546](https://togithub.com/chaijs/chai/pull/1546)

#### New Contributors

- [@&#8203;Izzur](https://togithub.com/Izzur) made their first
contribution in
[https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413)
- [@&#8203;stevenjoezhang](https://togithub.com/stevenjoezhang) made
their first contribution in
[https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400)
- [@&#8203;43081j](https://togithub.com/43081j) made their first
contribution in
[https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498)

**Full Changelog**:
chaijs/chai@4.3.1...v5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/runtime-env/import-meta-env).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Jul 16, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@guram21 guram21 mentioned this pull request Sep 22, 2024
Merged
@WontonSam WontonSam mentioned this pull request Sep 25, 2024
Open
@guram21 guram21 mentioned this pull request Sep 29, 2024
Merged
@WontonSam WontonSam mentioned this pull request Oct 1, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 11, 2024
Open
@nerds-github nerds-github mentioned this pull request Oct 23, 2024
Open
This was referenced Oct 25, 2024
Open
Open
This was referenced Nov 1, 2024
Open
Open
This was referenced Nov 6, 2024
Open
Open
@doperiddle doperiddle mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koddsson @43081j @keithamus