Replacing Karma with Web Test Runner #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
changed the title
43081j
reviewed
Oct 22, 2023
koddsson
force-pushed
the
web-test-runner
branch
from
57794af
to
11b3e98
Compare
|
Looks like Safari has some nonstandard |
|
I actually just dropped checking in Safari. These issues also exist on branch 5.x.x but it looks like we've never tested in Safari before. Since WebKit uses a different standard than V8 we'd need to normalise the stack trace somehow but I'd say that it's out of scope for this work. Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack |
keithamus
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web Test Runner is a pretty good test runner that runs tests in browsers and a good replacement for Karma.